Skip to content

Bump QCheck to 0.26 (and fix float comparisons) #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmid merged 2 commits into from
Jul 10, 2025
Merged

Bump QCheck to 0.26 (and fix float comparisons) #565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a9ea2e
Bump QCheck to 0.26
jmid Jul 10, 2025
20a9468
Use Float.equal to compare floats in postcond
jmid Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/common.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ jobs:
uses: actions/checkout@v4
with:
repository: c-cube/qcheck
ref: v0.25
ref: v0.26
path: multicoretests/qcheck

- name: Pre-Setup
Expand Down
4 changes: 2 additions & 2 deletions src/floatarray/stm_tests.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ struct
| Get i, Res ((Result (Float,Exn),_), r) ->
if i < 0 || i >= List.length s
then r = Error (Invalid_argument "index out of bounds")
else r = Ok (List.nth s i)
else Result.equal ~ok:Float.equal ~error:(=) r (Ok (List.nth s i))
| Set (i,_), Res ((Result (Unit,Exn),_), r) ->
if i < 0 || i >= List.length s
then r = Error (Invalid_argument "index out of bounds")
Expand All @@ -128,7 +128,7 @@ struct
| To_list, Res ((List Float,_),fs) -> List.equal Float.equal fs s
| Mem f, Res ((Bool,_),r) -> r = List.mem f s
| Sort, Res ((Unit,_),r) -> r = ()
| To_seq, Res ((Seq Float,_),r) -> Seq.equal (=) r (List.to_seq s)
| To_seq, Res ((Seq Float,_),r) -> Seq.equal Float.equal r (List.to_seq s)
| _, _ -> false
end

Expand Down