Use QCheck.Print combinators in Util.Pp printers for consistency#566
Merged
Conversation
Collaborator
Author
|
Ah dang, a negative nan is just printed as ddcebf1 removes the negative nan expect test case (temporarily) in order to move forward with the PR. |
Collaborator
Author
I've opened an upstream issue on QCheck here: c-cube/qcheck#353 |
Collaborator
Author
|
CI summary for ddcebf1: All 50 workflows passed |
Collaborator
Author
|
CI summary for merge to
Out of 51 workflows 1 workflow failed with (what appears to be) a genuine issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #565 I discovered that
STMargument and result printers differed causing a negativenanto display asnanas an argument toSet, yet it would print as-nanin the result, sending me on a goose chase. #562 was another example of outputs differing slightly.Following the principle of least surprise, this PR switches all
Util.Ppprinters for base types to use theQCheck.Printcombinators. I believe this further makes sense, since our opam packages are named with aqcheckprefix.I don't claim that, e.g., the
QCheck.Print.floatprinter is perfect as witnessed by the expect test output updates (e.g.,infinityis valid copy-pasteble OCaml, whereasinfis not) but I would rather have to only improve such a combinator in a single, central location.