Adjust Gc.stat stack_size check after 5.5 restoration#567
Merged
Conversation
Collaborator
Author
|
CI summary: all 50 workflows passed |
Collaborator
Author
|
CI summary for merge to |
dra27
added a commit
to MisterDA/ocaml
that referenced
this pull request
Oct 5, 2025
jmid
added a commit
to jmid/ocaml
that referenced
this pull request
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test suite is failing on 5.5+trunk on the
Gctests.This is due to the
stack_sizeentry ofGc.statnow being restored in ocaml/ocaml#14168 which would previously be constantly zero on OCaml 5.The PR relaxes the check for the entry for 5.5 and upward.