Adjust the exception matched in domain/domain_spawntree.ml#571
Merged
Conversation
Collaborator
Author
|
CI summary: all 50 workflows passed |
Collaborator
Author
|
CI summary for merge to |
jmid
added a commit
to jmid/ocaml
that referenced
this pull request
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The merge to
mainof the 0.10 release branch triggered a new error ontrunk, e.g. on macOS ARM64:https://github.com/ocaml-multicore/multicoretests/actions/runs/18315096994/job/52153110419
This is because the
domain_spawntree.mltest matches on the exception name in case of failure (generally a bad idea, but OK'ish when testing a runtime system and Stdlib against regressions), and the just merged ocaml/ocaml#12410 changed the error message slightly.This PR therefore updates the
Failureexception message check.