Remove the build directory as soon as possible when installing a package#6906
Open
kit-ty-kate wants to merge 2 commits into
Open
Remove the build directory as soon as possible when installing a package#6906kit-ty-kate wants to merge 2 commits into
kit-ty-kate wants to merge 2 commits into
Conversation
Member
Author
|
Tested over 40_000 times with great success together with #6440. Max disk + RAM usage goes from 4-10GB down to < 2GB per install. |
rjbou
reviewed
Apr 28, 2026
Collaborator
rjbou
left a comment
rjbou
left a comment
There was a problem hiding this comment.
Génial! lgtm on the idea.
tiny comment + it worth adding a bench if possible.
| @@ -868,13 +876,7 @@ let parallel_apply t | |||
| | `Remove nv -> | |||
| OpamAction.cleanup_package_artefacts t nv | |||
| (* if reinstalled, only removes build dir *) | |||
Collaborator
There was a problem hiding this comment.
This comment is tied to which line ?
kit-ty-kate
added
the
PR: QUEUED
kit-ty-kate
force-pushed
the
rm-build-dir-asap
branch
from
b0da0ac to
186730d
Compare
Member
Author
done. I've added the bench in #6912 and rebased this PR on top of it to check the result. |
kit-ty-kate
force-pushed
the
rm-build-dir-asap
branch
2 times, most recently
from
9988153 to
1127e6e
Compare
kit-ty-kate
force-pushed
the
rm-build-dir-asap
branch
from
6adb851 to
db02709
Compare
Member
Author
|
Compared to baseline (#6912), the benchmark shows a 0.3% performance degradation of regular installs and a 5% performance improvement on IO-constrained filesystems (simulated as much as i could) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5884
Queued on #6912