Remove unnecessary use of chdir

[NathanReb]

This ports the chdir removal from #5966 as asked for in #6600.

[kit-ty-kate]

The tests need to be adapted to the new API (tests/lib/patcher uses chdir)

[kit-ty-kate]

On top of #6600, this should hopefully also fix #3171

[NathanReb]

The test failures seem to all come from opam-rt builds. I guess it needs to be patched as well.

This could make us reconsider the removal of the chdir dependant API entries as this constitutes a breaking API change.

I could simply reintroduce them now that we know they're not used internally anymore but I assume the goal is to discourage their use entirely in opam so removing them feels right.

Let me know what you'd prefer here. I wonder if we could use some neat trick to deprecate them internally without the warning hitting external users, this would make for a good in between.

Edit: I forgot to hit Comment. I saw your PR on but still wanted to open the discussion on the breaking API change.

[kit-ty-kate]

The test failures seem to all come from opam-rt builds. I guess it needs to be patched as well.

done in ocaml-opam/opam-rt#89

[NathanReb]

Any idea what's wrong with this build in particular: https://github.com/ocaml/opam/actions/runs/25102824494/job/73556728915?pr=6910

The error:

diff --git a/_build/default/tests/reftests/pin.test b/_build/default/tests/reftests/pin.out
File "tests/reftests/pin.test", line 1, characters 0-0:
index 581969b..baf3f8d 100644
/usr/bin/git --no-pager diff --no-index --color=always -u _build/default/tests/reftests/pin.test _build/default/tests/reftests/pin.out
--- a/_build/default/tests/reftests/pin.test
Command exited with code 1.
+++ b/_build/default/tests/reftests/pin.out
@@ -241,8 +241,8 @@ The following actions will be performed:
 -> installed nip-git2.ved
 Done.
 ### opam pin add ./nip-path2 --kind git | sed-cmd git | "128.*" -> "128"
-[ERROR] Command "git -C ${BASEDIR}/nip-path2 ls-files" failed:
-"git -C ${BASEDIR}/nip-path2 ls-files" exited with code 128
+[ERROR] Command "git -C /tmp/build_e05667_dune/opam-reftest-c7128
+"git -C /tmp/build_e05667_dune/opam-reftest-c7128
 # Return code 99 #
 ### : auto
 ### opam pin add ./nip-git3 --kind auto
make: *** [Makefile:217: tests] Error 1
Error: Process completed with exit code 2.

[NathanReb]

Ah just got it, the regexp matched on the generated directory name! I'll see if I can make the regexp more robust!

[NathanReb]

Maybe that should in fact be fixed at the reftest-runner level though, it seems the regexp was applied before the path normalization, I doubt there is any concrete case where we want that. Let me know what you'd prefer!

[NathanReb]

I went for the former. A bit of testing showed that the changes in the reftest runner would be a bit more involved than I anticipated as in some tests at least, sed-cmd as to be run before the common_filters so we'd need a finer orderding than simply common_filters @ filters.

[NathanReb]

rebased on top of #6922 to show the impact on the opam pin list bug.

[NathanReb]

Is anything still blocking this?

[rjbou]

Tiny comments, otherwise, lgtm!

[kit-ty-kate]

Thanks!