tests: Fix issues with hook tests

Author: ocean

ENHANCEMENTS.md

@@ -355,16 +355,16 @@ config :my_app, MyApp.Repo,
 **Reason**: Rustler threading model incompatibility
 
 **Why Not Supported**:
-Both update hooks and authorizer hooks are fundamentally incompatible with Rustler's threading model:
+Both update hooks and authoriser hooks are fundamentally incompatible with Rustler's threading model:
 
 1. **Update Hooks Problem**:
    - SQLite's update hook callback runs synchronously during INSERT/UPDATE/DELETE operations
    - Callback executes on Erlang scheduler threads (managed by BEAM)
    - Rustler's `OwnedEnv::send_and_clear()` can ONLY be called from unmanaged threads
    - Calling `send_and_clear()` from managed thread causes panic: "current thread is managed"
 
-2. **Authorizer Hooks Problem**:
-   - SQLite's authorizer callback is synchronous and expects immediate response (Allow/Deny/Ignore)
+2. **Authoriser Hooks Problem**:
+   - SQLite's authoriser callback is synchronous and expects immediate response (Allow/Deny/Ignore)
    - Would require blocking Rust thread waiting for Elixir response
    - No safe way to do synchronous Rust→Elixir→Rust calls
    - Blocking on scheduler threads can cause deadlocks
@@ -377,8 +377,8 @@ For **Change Data Capture / Real-time Updates**:
 - Polling-based CDC with timestamps
 - Phoenix.Tracker for state tracking
 
-For **Row-Level Security / Authorization**:
-- Application-level authorization checks before queries
+For **Row-Level Security / Authorisation**:
+- Application-level authorisation checks before queries
 - Database views with WHERE clauses
 - Query rewriting in Ecto
 - Connection-level privileges
@@ -445,13 +445,13 @@ For **Row-Level Security / Authorization**:
 ### Potential Enhancements
 1. **Haversine Formula**: Implement actual geographic distance calculations for accuracy
 2. **Higher Dimensions**: Support for more complex geospatial data (elevation, time, etc.)
-3. **Index Optimization**: Add spatial indexes for performance on large datasets
+3. **Index Optimisation**: Add spatial indexes for performance on large datasets
 4. **Batch Queries**: Use batch operations for multiple location lookups
 5. **Clustering**: Find geographic clusters of locations using vector analysis
 
 ### Real-World Applications
 - **Location-based services**: Find nearby restaurants, hotels, gas stations
-- **Delivery optimization**: Locate nearest warehouse to customer location
+- **Delivery optimisation**: Locate nearest warehouse to customer location
 - **Regional analytics**: Find closest office/branch in each region
 - **Social discovery**: Find nearby users, events, or meetup groups
 - **Asset tracking**: Locate nearest available equipment or resources
@@ -885,4 +885,4 @@ disallowed-methods = [
 8. **Ecto Integration Improvements**
 9. **P3 Low Priority Features**
 
-This prioritization ensures we address the most critical production issues first, then focus on performance and reliability, before moving to nice-to-have features and advanced functionality.
+This prioritisation ensures we address the most critical production issues first, then focus on performance and reliability, before moving to nice-to-have features and advanced functionality.

lib/ecto_libsql/native.ex

@@ -992,8 +992,8 @@ defmodule EctoLibSql.Native do
     - `:unsupported` - Always returns unsupported
 
   """
-  def add_update_hook(%EctoLibSql.State{} = state, _pid \\ self()) do
-    set_update_hook(state.conn_id, self())
+  def add_update_hook(%EctoLibSql.State{} = state, pid \\ self()) do
+    set_update_hook(state.conn_id, pid)
   end
 
   @doc """

native/ecto_libsql/src/hooks.rs

@@ -5,7 +5,7 @@
 ///
 /// **CURRENT STATUS**: Both update hooks and authorizer hooks are currently **NOT SUPPORTED**
 /// due to fundamental threading limitations with Rustler and the BEAM VM.
-use rustler::{Atom, LocalPid, NifResult};
+use rustler::{Atom, Env, LocalPid, NifResult};
 
 /// Set update hook for a connection
 ///
@@ -62,8 +62,11 @@ use rustler::{Atom, LocalPid, NifResult};
 /// # Returns
 /// - `{:error, :unsupported}` - Always returns unsupported
 #[rustler::nif]
-pub fn set_update_hook(_conn_id: &str, _pid: LocalPid) -> NifResult<Atom> {
-    Err(rustler::Error::Atom("unsupported"))
+pub fn set_update_hook(env: Env, _conn_id: &str, _pid: LocalPid) -> NifResult<(Atom, Atom)> {
+    Ok((
+        Atom::from_str(env, "error")?,
+        Atom::from_str(env, "unsupported")?,
+    ))
 }
 
 /// Clear update hook for a connection
@@ -76,8 +79,11 @@ pub fn set_update_hook(_conn_id: &str, _pid: LocalPid) -> NifResult<Atom> {
 /// # Returns
 /// - `{:error, :unsupported}` - Always returns unsupported
 #[rustler::nif]
-pub fn clear_update_hook(_conn_id: &str) -> NifResult<Atom> {
-    Err(rustler::Error::Atom("unsupported"))
+pub fn clear_update_hook(env: Env, _conn_id: &str) -> NifResult<(Atom, Atom)> {
+    Ok((
+        Atom::from_str(env, "error")?,
+        Atom::from_str(env, "unsupported")?,
+    ))
 }
 
 /// Set authorizer hook for a connection
@@ -148,6 +154,9 @@ pub fn clear_update_hook(_conn_id: &str) -> NifResult<Atom> {
 /// # Returns
 /// - `{:error, :unsupported}` - Always returns unsupported
 #[rustler::nif]
-pub fn set_authorizer(_conn_id: &str, _pid: LocalPid) -> NifResult<Atom> {
-    Err(rustler::Error::Atom("unsupported"))
+pub fn set_authorizer(env: Env, _conn_id: &str, _pid: LocalPid) -> NifResult<(Atom, Atom)> {
+    Ok((
+        Atom::from_str(env, "error")?,
+        Atom::from_str(env, "unsupported")?,
+    ))
 }

test/hooks_test.exs

@@ -13,16 +13,16 @@ defmodule EctoLibSql.HooksTest do
 
   describe "add_update_hook/2 - NOT SUPPORTED" do
     test "returns :unsupported error", %{state: state} do
-      assert :unsupported = Native.add_update_hook(state)
+      assert {:error, :unsupported} = Native.add_update_hook(state)
     end
 
     test "returns :unsupported with custom PID", %{state: state} do
       test_pid = self()
-      assert :unsupported = Native.add_update_hook(state, test_pid)
+      assert {:error, :unsupported} = Native.add_update_hook(state, test_pid)
     end
 
     test "does not affect database operations", %{state: state} do
-      :unsupported = Native.add_update_hook(state)
+      {:error, :unsupported} = Native.add_update_hook(state)
 
       # Database operations should still work
       {:ok, _, _, _state} =
@@ -47,27 +47,27 @@ defmodule EctoLibSql.HooksTest do
 
   describe "remove_update_hook/1 - NOT SUPPORTED" do
     test "returns :unsupported error", %{state: state} do
-      assert :unsupported = Native.remove_update_hook(state)
+      assert {:error, :unsupported} = Native.remove_update_hook(state)
     end
 
     test "can be called multiple times safely", %{state: state} do
-      assert :unsupported = Native.remove_update_hook(state)
-      assert :unsupported = Native.remove_update_hook(state)
+      assert {:error, :unsupported} = Native.remove_update_hook(state)
+      assert {:error, :unsupported} = Native.remove_update_hook(state)
     end
   end
 
   describe "add_authorizer/2 - NOT SUPPORTED" do
     test "returns :unsupported error", %{state: state} do
-      assert :unsupported = Native.add_authorizer(state)
+      assert {:error, :unsupported} = Native.add_authorizer(state)
     end
 
     test "returns :unsupported with custom PID", %{state: state} do
       test_pid = self()
-      assert :unsupported = Native.add_authorizer(state, test_pid)
+      assert {:error, :unsupported} = Native.add_authorizer(state, test_pid)
     end
 
     test "does not affect database operations", %{state: state} do
-      :unsupported = Native.add_authorizer(state)
+      {:error, :unsupported} = Native.add_authorizer(state)
 
       # Database operations should still work
       {:ok, _, _, _state} =