fix(logservice): persist PodIP before Running and stabilize node deletion

- oblogservicenode UpdateStatus: refresh PodIP/phase unconditionally
  (not only when Status==Running) so Pod-IP mode bootstrap can read the
  node connect address. Preserves the B5 guard (empty PodIP does not
  overwrite last-known IP) and keeps recovery gating on Running.
- oblogservicezone: move sortDeleteCandidates to manager.go (no-return
  func crashes the task_register generator in _task.go); add name
  tiebreaker for deterministic deletion ordering.

Author: Junkrat77

internal/resource/oblogservicenode/oblogservicenode_manager.go

@@ -146,26 +146,36 @@ func (m *OBLogServiceNodeManager) UpdateStatus() error {
 		}
 	}
 
-	if m.Resource.Status.Status == nodestatus.Running {
-		pod := &corev1.Pod{}
+	// Refresh PodIP/phase from the current pod whenever it exists, so that
+	// bootstrap (which needs the node connect address) can read the PodIP even
+	// before the node reaches Running. This mirrors the unconditional ServiceIP
+	// refresh above and is required for Pod-IP mode where the connect address
+	// is the PodIP itself.
+	pod := &corev1.Pod{}
+	if m.Resource.Status.PodName != "" {
 		err := m.Client.Get(m.Ctx, types.NamespacedName{
 			Namespace: m.Resource.Namespace,
 			Name:      m.Resource.Status.PodName,
 		}, pod)
-		if err != nil {
-			if kubeerrors.IsNotFound(err) {
-				m.Logger.Info("LogService node pod not found, need recovery", "pod", m.Resource.Status.PodName)
-				m.setRecoveryStatus()
-			} else {
-				return err
-			}
-		} else {
+		if err != nil && !kubeerrors.IsNotFound(err) {
+			return err
+		}
+		if err == nil {
 			m.Resource.Status.PodPhase = pod.Status.Phase
 			// A failed/evicted pod may report an empty PodIP; keep the last
 			// known IP so recovery can pin the recreated pod to it.
 			if pod.Status.PodIP != "" {
 				m.Resource.Status.PodIP = pod.Status.PodIP
 			}
+		}
+	}
+
+	if m.Resource.Status.Status == nodestatus.Running {
+		if m.Resource.Status.PodName != "" && pod.Name == "" {
+			// Pod lookup above returned NotFound; need recovery.
+			m.Logger.Info("LogService node pod not found, need recovery", "pod", m.Resource.Status.PodName)
+			m.setRecoveryStatus()
+		} else if pod.Name != "" {
 			m.Resource.Status.Ready = pod.Status.Phase == corev1.PodRunning
 			if pod.Status.Phase == corev1.PodFailed {
 				m.Logger.Info("LogService node pod in Failed phase, need recovery", "pod", m.Resource.Status.PodName)

internal/resource/oblogservicezone/oblogservicezone_manager.go

@@ -14,6 +14,7 @@ package oblogservicezone
 
 import (
 	"context"
+	"sort"
 
 	"github.com/go-logr/logr"
 	corev1 "k8s.io/api/core/v1"
@@ -223,3 +224,24 @@ func (m *OBLogServiceZoneManager) listNodes() (*v1alpha1.OBLogServiceNodeList, e
 	}
 	return nodeList, nil
 }
+
+// sortDeleteCandidates orders nodes for deletion: unrecoverable first, then
+// newest first, with node name as a deterministic tiebreaker so two independent
+// list+sort calls select the same set even when CreationTimestamps are equal.
+// Defined here (not in _task.go) because it has no return value, which the
+// task_register generator cannot scan.
+func sortDeleteCandidates(nodes []v1alpha1.OBLogServiceNode) {
+	sort.SliceStable(nodes, func(i, j int) bool {
+		iUnrecoverable := nodes[i].Status.Status == nodestatus.Unrecoverable
+		jUnrecoverable := nodes[j].Status.Status == nodestatus.Unrecoverable
+		if iUnrecoverable != jUnrecoverable {
+			return iUnrecoverable
+		}
+		ti := nodes[i].CreationTimestamp.Time
+		tj := nodes[j].CreationTimestamp.Time
+		if !ti.Equal(tj) {
+			return ti.After(tj)
+		}
+		return nodes[i].Name < nodes[j].Name
+	})
+}

internal/resource/oblogservicezone/oblogservicezone_task.go

@@ -15,7 +15,6 @@ package oblogservicezone
 
 import (
 	"fmt"
-	"sort"
 	"time"
 
 	"github.com/pkg/errors"
@@ -489,22 +488,6 @@ func UnregisterAllNodesFromCluster(m *OBLogServiceZoneManager) tasktypes.TaskErr
 	return nil
 }
 
-func sortDeleteCandidates(nodes []v1alpha1.OBLogServiceNode) {
-	sort.SliceStable(nodes, func(i, j int) bool {
-		iUnrecoverable := nodes[i].Status.Status == nodestatus.Unrecoverable
-		jUnrecoverable := nodes[j].Status.Status == nodestatus.Unrecoverable
-		if iUnrecoverable != jUnrecoverable {
-			return iUnrecoverable
-		}
-		ti := nodes[i].CreationTimestamp.Time
-		tj := nodes[j].CreationTimestamp.Time
-		if !ti.Equal(tj) {
-			return ti.After(tj)
-		}
-		return nodes[i].Name < nodes[j].Name
-	})
-}
-
 func (m *OBLogServiceZoneManager) getRunningNodeHttpAddr(excludeNames ...string) (string, error) {
 	excludeSet := make(map[string]bool, len(excludeNames))
 	for _, n := range excludeNames {