calling refresh_index before query#217
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughExamples and documentation now consistently demonstrate calling ChangesIndex Refresh Pattern Documentation and Examples
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…#222) ## Summary - Remove the early return in `_transform_sql_result` for empty `result_rows`, so empty hybrid/search results respect the `include` parameter instead of always returning all columns. - Add unit tests covering empty-result shape for `include=None`, `include=[]`, and `include=["embeddings"]`. - Call `collection.refresh_index()` before hybrid search in the integration test so index state is ready after recent `refresh_index`-before-query behavior (#217). ## Test plan - [x] `uv run pytest tests/unit_tests/test_hybrid_search_source_inference.py` - [ ] `uv run pytest tests/integration_tests/test_collection_hybrid_search_source_inference.py` (requires real DB) Made with [Cursor](https://cursor.com) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Fixed handling of empty search results to return consistent column structures based on the requested data types. * **Tests** * Added test coverage for empty result scenarios to verify correct column structure across various configuration options. <!-- review_stack_entry_start --> [](https://app.coderabbit.ai/change-stack/oceanbase/pyseekdb/pull/222?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack) <!-- review_stack_entry_end --> <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: Cursor <cursoragent@cursor.com>
<!-- Thank you for contributing to OceanBase! Please feel free to ping the maintainers for the review! --> ## Summary <!-- Please clearly and concisely describe the purpose of this pull request. If this pull request resolves an issue, please link it via "close #xxx" or "fix #xxx". --> calling refresh_index before query. Fix the examples which doesn't calling refresh_index() interface. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Updated README Quick Start guide and example scripts to include index refresh after document insertion * Ensures consistent demonstration of search workflows across all documentation [](https://app.coderabbit.ai/change-stack/oceanbase/pyseekdb/pull/217) <!-- end of auto-generated comment: release notes by coderabbit.ai -->
…oceanbase#222) ## Summary - Remove the early return in `_transform_sql_result` for empty `result_rows`, so empty hybrid/search results respect the `include` parameter instead of always returning all columns. - Add unit tests covering empty-result shape for `include=None`, `include=[]`, and `include=["embeddings"]`. - Call `collection.refresh_index()` before hybrid search in the integration test so index state is ready after recent `refresh_index`-before-query behavior (oceanbase#217). ## Test plan - [x] `uv run pytest tests/unit_tests/test_hybrid_search_source_inference.py` - [ ] `uv run pytest tests/integration_tests/test_collection_hybrid_search_source_inference.py` (requires real DB) Made with [Cursor](https://cursor.com) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Fixed handling of empty search results to return consistent column structures based on the requested data types. * **Tests** * Added test coverage for empty result scenarios to verify correct column structure across various configuration options. <!-- review_stack_entry_start --> [](https://app.coderabbit.ai/change-stack/oceanbase/pyseekdb/pull/222?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack) <!-- review_stack_entry_end --> <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: Cursor <cursoragent@cursor.com>
Summary
calling refresh_index before query.
Fix the examples which doesn't calling refresh_index() interface.
Summary by CodeRabbit