delete to_cstring

Co-authored-by: hnwyllmm <hnwyllmm@users.noreply.github.com>

Author: obdev

deps/oblib/src/lib/utility/ob_print_utils.cpp

@@ -367,29 +367,18 @@ int64_t to_string<bool>(const bool &v, char *buffer, const int64_t buffer_size)
   return pos;
 }
 
-template <>
-const char *to_cstring<const char *>(const char *const &str)
-{
-  return str;
-}
-
-template <>
-const char *to_cstring<int64_t>(const int64_t &v)
-{
-  return to_cstring<int64_t>(v, BoolType<false>());
-}
 ////////////////////////////////////////////////////////////////
 
-const int64_t ObCStringHelperV2::EXPAND_BUF_LEN;
-const int64_t ObCStringHelperV2::HELPER_MEMORY_LIMIT;
+const int64_t ObCStringHelper::EXPAND_BUF_LEN;
+const int64_t ObCStringHelper::HELPER_MEMORY_LIMIT;
 
 ERRSIM_POINT_DEF(EN_CSTRING_HELPER_FORCE_MALLOC);
-bool ObCStringHelperV2::is_force_alloc()
+bool ObCStringHelper::is_force_alloc()
 {
   return EN_CSTRING_HELPER_FORCE_MALLOC;
 }
 
-void ObCStringHelperV2::force_alloc()
+void ObCStringHelper::force_alloc()
 {
   buf_ = reinterpret_cast<char *>(allocator_.alloc(buf_len_));
   if (nullptr == buf_) {

deps/oblib/src/lib/utility/ob_print_utils.h

@@ -303,11 +303,6 @@ const char *to_cstring(const T &obj)
   return to_cstring(obj, BoolType<HAS_MEMBER(T, to_cstring)>());
 }
 
-template <>
-const char *to_cstring<const char *>(const char *const &str);
-template <>
-const char *to_cstring<int64_t>(const int64_t &v);
-
 template <typename T>
 const char *to_cstring(T *obj)
 {
@@ -424,12 +419,12 @@ int databuff_print_multi_objs(char* buf, const int64_t buf_len, int64_t &pos, co
 ObCStringHelper: convert the object to cstring with an inner buffer
 If you need a persistent cstring, you cannot use this class.
 */
-class ObCStringHelperV2
+class ObCStringHelper
 {
   const static int64_t EXPAND_BUF_LEN = 16L << 10;
   const static int64_t HELPER_MEMORY_LIMIT = 64L << 20;
 public:
-  ObCStringHelperV2()
+  ObCStringHelper()
     : allocator_(SET_USE_500("CStringHelper"))
   {
 #ifdef ENABLE_DEBUG_LOG
@@ -513,7 +508,7 @@ class ObCStringHelperV2
   void force_alloc();
 
 private:
-  DISABLE_COPY_ASSIGN(ObCStringHelperV2);
+  DISABLE_COPY_ASSIGN(ObCStringHelper);
 private:
   ObArenaAllocator allocator_;
   char reserve_buf_[1024];
@@ -523,25 +518,6 @@ class ObCStringHelperV2
   int ob_errno_ = OB_SUCCESS;
 };
 
-class ObCStringHelper
-{
-public:
-  template<typename T>
-  const char *convert(const T &obj)
-  {
-    return to_cstring(obj);
-  }
-  template<typename T>
-  int convert(const T &obj, const char *&str)
-  {
-    str = to_cstring(obj);
-    return NULL == str ? OB_ERROR : OB_SUCCESS;
-  }
-  void reset()
-  {
-  }
-};
-
 /// @return OB_SUCCESS or OB_ALLOCATE_MEMORY_FAILED
 int multiple_extend_buf(char *&stmt_buf, int64_t &stmt_buf_len, common::ObIAllocator &alloc);
 /// @return OB_SUCCESS or OB_SIZE_OVERFLOW