Skip to content

fix: the wrong logic of constraint checker#540

Closed
ep-12221 wants to merge 425 commits intooceanbase:masterfrom
ep-12221:fix/issue530
Closed

fix: the wrong logic of constraint checker#540
ep-12221 wants to merge 425 commits intooceanbase:masterfrom
ep-12221:fix/issue530

Conversation

@ep-12221
Copy link
Copy Markdown

@ep-12221 ep-12221 commented Apr 13, 2026

fix: ALTER TABLE modifying multiple NOT NULL constraints in one statement does not error as expected

Change the condition in
ObAlterTableConstraintChecker::check_can_add_cst_on_multi_column()
from OB_INVALID_ID == *(*iter)->cst_col_begin() to
OB_INVALID_ID != *(*iter)->cst_col_begin().

OB_INVALID_ID means the NOT NULL constraint belongs to a newly added
column whose column id has not been assigned yet. Multi-column ADD
NOT NULL should only be allowed for that case. The old check treated
multi-column MODIFY ... NOT NULL on existing columns as a valid
multi-column ADD path, so ALTER TABLE succeeded instead of reporting
the expected not supported error.

ref: #530

obdev and others added 30 commits December 4, 2025 02:38
@footka @ob-robot
[CP] [fix] hybrid vector index refresh task return 5024
d21c697 
Co-authored-by: footka <672528926@qq.com>
@footka @ob-robot
[CP] Add backticks to database names, table names, column names, and …
f379907 
…alias names.

Co-authored-by: footka <672528926@qq.com>
@footka @ob-robot
[CP]fix ai function error code
cf93e14 
Co-authored-by: footka <672528926@qq.com>
@footka @ob-robot
[CP]fix ai model endpoint create behavier
fc85fc8 
Co-authored-by: footka <672528926@qq.com>
@helloamateur @ob-robot
fix mysqltest
ee7df3d 
Co-authored-by: helloamateur <magiccheery@163.com>
@footka @ob-robot
[CP] fix pipeline set snapshot key prefix
43466ed 
Co-authored-by: footka <672528926@qq.com>
@footka @ob-robot
[CP] fix alter table drop index for hnsw heap table
32145b5 
Co-authored-by: footka <672528926@qq.com>
@footka @ob-robot
[CP] fix dml set can_skip flag of hybrid vector index adaptor
25b82fd 
Co-authored-by: footka <672528926@qq.com>
@footka @ob-robot
[CP] [vector index] fix replace into with sixth table part key issue
9d3eb42 
Co-authored-by: footka <672528926@qq.com>
@footka @ob-robot
[CP] [vector index] fix parellel dml error
2c6b650 
Co-authored-by: footka <672528926@qq.com>
@footka @ob-robot
[CP] fix hnsw insert on duplicate key update
666df29 
Co-authored-by: footka <672528926@qq.com>
@footka @ob-robot
[CP] [fix] hybrid vector index refresh task memory bloat
8664da6 
Co-authored-by: footka <672528926@qq.com>
@footka @miyuan-ljr @ob-robot
[CP] [fix] insert on dup error 5500
0216742 
Co-authored-by: footka <672528926@qq.com>
Co-authored-by: 884244693 <884244693@qq.com>
@footka @ob-robot
[CP] [fix] hybrid vector manual execute rebuild hung
b55102f 
Co-authored-by: footka <672528926@qq.com>
@footka @ob-robot
[CP] [fix] vector index offline ddl hung when create failed
7262d30 
Co-authored-by: footka <672528926@qq.com>
@footka @ob-robot
[CP] [fix] hybrid refresh error 6005
dcf78c5 
Co-authored-by: footka <672528926@qq.com>
@footka @shadowao @ob-robot
fix add vector fail but insert bitmap is set when supplement data for…
0d8355f 
… incr hnsw

Co-authored-by: footka <672528926@qq.com>
Co-authored-by: shadowao <aozeliu@qq.com>
@footka @LINxiansheng @ob-robot
remove cos
d1211e9 
Co-authored-by: footka <672528926@qq.com>
Co-authored-by: LINxiansheng <wangzelin19961202@gmail.com>
@footka @ob-robot
[CP] fix sparse vector mem leak
93bcb85 
Co-authored-by: footka <672528926@qq.com>
@footka @miyuan-ljr @ob-robot
[CP] [fix] hybrid task return 4016 caused by null ptr
cd0382c 
Co-authored-by: footka <672528926@qq.com>
Co-authored-by: 884244693 <884244693@qq.com>
@footka @ob-robot
[CP] [fix] hybrid vector index refresh core at deconstruct embedding …
ea66579 
…task

Co-authored-by: footka <672528926@qq.com>
@footka @ob-robot
[CP] [fix] hybrid vector index refresh error 4002 on heap table with …
d85c6b9 
…subpartition

Co-authored-by: footka <672528926@qq.com>
@footka @ob-robot
[CP] [hybrid vector index]fix save_distance_expr_result && refresh ta…
a8b4259 
…sk del partition emdeded table

Co-authored-by: footka <672528926@qq.com>
@footka @ob-robot
[CP] update报错[errcode=-4377] fatal internal error in [check_old_row_l…
5715118 
…egitimacy]

Co-authored-by: footka <672528926@qq.com>
@footka @ob-robot
[CP] core fix
9bb1530 
Co-authored-by: footka <672528926@qq.com>
@footka @ob-robot
[CP] core at oceanbase::common::databuff_print_key_obj
9d24b88 
Co-authored-by: footka <672528926@qq.com>
@ob-robot
[CP] [vector index] fix expr core and empty data issue
b329ac7
@ob-robot
[CP] [hybrid vector index] fix build_rowkey_domain_range for embeded …
0b73345 
…table
@ob-robot
[CP] fix select heap table with vector index when in list expr rewrit…
628f2ee 
…e to subquery
@ob-robot
[CP] Fix: Return 1210 for empty string in semantic_distance
aed0d54
obdev and others added 26 commits April 3, 2026 16:25
@footka @gaopy3 @ob-robot
[CP] Patch DDL optimization
e686da6 
Co-authored-by: footka <672528926@qq.com>
Co-authored-by: gaopy3 <gao.panyu@qq.com>
@wyfanxiao @haitaoy @ob-robot
[CP] advance scan bug fix
6006e21 
Co-authored-by: wyfanxiao <wyfanxiao@163.com>
Co-authored-by: haitaoy <haitaoy3.14@gmail.com>
@footka @Garfiled @ob-robot
fix change stream dispatch exec_ctx bug
955469d 
Co-authored-by: footka <672528926@qq.com>
Co-authored-by: Garfiled <799044397@qq.com>
@wyfanxiao @LesinLi @ob-robot
[android] Support build android apk package
7de51da 
Co-authored-by: wyfanxiao <wyfanxiao@163.com>
Co-authored-by: LesinLi <15649865651@163.com>
@footka @xiebaoma @ob-robot
fix: allow SYS tenant gc
20e300c 
Co-authored-by: footka <672528926@qq.com>
Co-authored-by: xiebaoma <2402583447@qq.com>
@footka @xiebaoma @ob-robot
[seekdb][异步索引] fix: check NULL before OUTROW
71db8fb 
Co-authored-by: footka <672528926@qq.com>
Co-authored-by: xiebaoma <2402583447@qq.com>
@footka @xiebaoma @ob-robot
[seekdb][异步索引]fix: use snapshot to read 4th table
80ea088 
Co-authored-by: footka <672528926@qq.com>
Co-authored-by: xiebaoma <2402583447@qq.com>
@footka @xiebaoma @ob-robot
fix: sparse_vector count
53d70df 
Co-authored-by: footka <672528926@qq.com>
Co-authored-by: xiebaoma <2402583447@qq.com>
@wyfanxiao @Poseidon-fan @ob-robot
Fork Table 与异步正交适配
7c34563 
Co-authored-by: wyfanxiao <wyfanxiao@163.com>
Co-authored-by: Poseidon-fan <18646154381@163.com>
@wyfanxiao @Poseidon-fan @ob-robot
Fork database 正交适配异步索引
c42e28a 
Co-authored-by: wyfanxiao <wyfanxiao@163.com>
Co-authored-by: Poseidon-fan <18646154381@163.com>
@wyfanxiao @LesinLi @ob-robot
fix(android): 修复数组与字符串字面量比较时误报 Invalid JSON text 的问题
a45f08f 
Co-authored-by: wyfanxiao <wyfanxiao@163.com>
Co-authored-by: LesinLi <15649865651@163.com>
@footka @ob-robot
Optimize read performance of standby
dbb8b2a 
Co-authored-by: footka <672528926@qq.com>
@wyfanxiao @fkuner @ob-robot
Prevent standby replay deadlock by using STRICT_BARRIER for DDL_TABLE…
0caeb70 
…_FORK_START_LOG

Co-authored-by: wyfanxiao <wyfanxiao@163.com>
Co-authored-by: fkuner <784819644@qq.com>
@wyfanxiao @Garfiled @ob-robot
optimise hnsw search for skip read 4th table
97d3110 
Co-authored-by: wyfanxiao <wyfanxiao@163.com>
Co-authored-by: Garfiled <799044397@qq.com>
@footka @Garfiled @ob-robot
fix async_index semantic index
42a4b85 
Co-authored-by: footka <672528926@qq.com>
Co-authored-by: Garfiled <799044397@qq.com>
@wyfanxiao @fkuner @ob-robot
Discard orphaned tx_info_ entries when CSFetcher transitions ACTIVE t…
e8f2bbf 
…o IDLE

Co-authored-by: wyfanxiao <wyfanxiao@163.com>
Co-authored-by: fkuner <784819644@qq.com>
@wyfanxiao @LINxiansheng @ob-robot
fix: use pointer comparison as fallback in sort comparator error stat…
5aa611c 
…e to prevent macOS crash

Co-authored-by: wyfanxiao <wyfanxiao@163.com>
Co-authored-by: LINxiansheng <wangzelin19961202@gmail.com>
@wyfanxiao @LINxiansheng @ob-robot
fix some core on windows
89a52de 
Co-authored-by: wyfanxiao <wyfanxiao@163.com>
Co-authored-by: LINxiansheng <wangzelin19961202@gmail.com>
@wyfanxiao @Poseidon-fan @ob-robot
修复 Fork Table 时索引表为列存格式的 bug
fec0210 
Co-authored-by: wyfanxiao <wyfanxiao@163.com>
Co-authored-by: Poseidon-fan <18646154381@163.com>
@footka @ob-robot
remove useless bloom filter code
ecd55d9 
Co-authored-by: footka <672528926@qq.com>
Co-authored-by: haiyuzhou <mock@aaa.com>
@wyfanxiao @fkuner @ob-robot
Prevent invalid LSN from over-advancing change stream refresh SCN
5852462 
Co-authored-by: wyfanxiao <wyfanxiao@163.com>
Co-authored-by: fkuner <784819644@qq.com>
@wyfanxiao @LesinLi @ob-robot
fix(android): 修复 Android 平台 array 类型比较运算符错误码不正确的问题
f00ffef 
Co-authored-by: wyfanxiao <wyfanxiao@163.com>
Co-authored-by: LesinLi <15649865651@163.com>
@wyfanxiao @Garfiled @ob-robot
Revert Merge branch 'issue/2026040800115232244' into 'master'
562a687 
Co-authored-by: wyfanxiao <wyfanxiao@163.com>
Co-authored-by: Garfiled <799044397@qq.com>
@wyfanxiao @LINxiansheng @ob-robot
fix compilation errors on Windows
e75cbf0 
Co-authored-by: wyfanxiao <wyfanxiao@163.com>
Co-authored-by: LINxiansheng <wangzelin19961202@gmail.com>
@wyfanxiao @LINxiansheng @ob-robot
pass secondary_namespace to PLPrepareCtx in spi_parse_prepare to avoi…
dd7a090 
…d crash on trigger referencing dropped column

Co-authored-by: wyfanxiao <wyfanxiao@163.com>
Co-authored-by: LINxiansheng <wangzelin19961202@gmail.com>
@ep-12221
fix: the wrong logic of constraint checker
ce1837d
@ob-robot ob-robot force-pushed the master branch 2 times, most recently from 682722e to 993d61e Compare April 23, 2026 13:51
@hnwyllmm hnwyllmm closed this Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ep-12221 @hnwyllmm