Skip to content

Bucket methods#154

Merged
giurgiur99 merged 3 commits intomainfrom
feat/storage-bucket-commands
Apr 23, 2026
Merged

Bucket methods#154
giurgiur99 merged 3 commits intomainfrom
feat/storage-bucket-commands

Conversation

@giurgiur99
Copy link
Copy Markdown
Contributor

@giurgiur99 giurgiur99 commented Apr 21, 2026

Fixes #153

Changes proposed in this PR:

  • createBucket, addFileToBucket, listBuckets, listFilesInBucket, getFileObject, deleteFile
  • fixed P2P wait loop in src/cli.ts to block on the target peer id
  • addFileToBucket streams files via fs.createReadStream (no buffering)

@giurgiur99 giurgiur99 marked this pull request as ready for review April 22, 2026 12:13
Copy link
Copy Markdown
Member

@ndrpp ndrpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
One issue I encountered when uploading a file:
Image
I checked the node storage and the file is indeed empty

@giurgiur99
Copy link
Copy Markdown
Contributor Author

Fix is here @ndrpp

oceanprotocol/ocean-node#1349

Deployed on test1 for testing

@ndrpp
Copy link
Copy Markdown
Member

ndrpp commented Apr 23, 2026

Fix is here @ndrpp

oceanprotocol/ocean-node#1349

Deployed on test1 for testing

Tested and works properly now 👍
image

@giurgiur99 giurgiur99 merged commit c85fd17 into main Apr 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

implement storage in Ocean CLI

2 participants