Feature/paid-compute in cli

[mariacarmina]

Fixes #113 .

Changes proposed in this PR:

• Create initializeCompute command and
• refator computeStart command to support new signature from ocean.js
• update ocean.js version to include paid compute

[giurgiur99]

Just some questions here from me. Nice job.

[bogdanfazakas]

Do we really need to have initializecompute command ? as a user i consider it out of scope for the cli, and the purpose would be be to have just a startCompute cmd that would handle everything under the hood

[mariacarmina]

Do we really need to have initializecompute command ? as a user i consider it out of scope for the cli, and the purpose would be be to have just a startCompute cmd that would handle everything under the hood

When we has the presentation of c2d paid flow, we agreed to have 2 methods, because initializeCompute returns the payment that needs to be processed by the end user and the end user needs to agree with the cost first and after trigger start compute.

[giurgiur99]

LGTM!

[mariacarmina]

Do we really need to have initializecompute command ? as a user i consider it out of scope for the cli, and the purpose would be be to have just a startCompute cmd that would handle everything under the hood

When we has the presentation of c2d paid flow, we agreed to have 2 methods, because initializeCompute returns the payment that needs to be processed by the end user and the end user needs to agree with the cost first and after trigger start compute.

Now startCompute includes initializeCompute logic and waits for user input regarding payment amount, there is additional option for accepting the payment without displaying the prompt to user.

[bogdanfazakas]

Looks good overall, but before merge update the readme and command will be useful because for eg we have

Start Compute:

Positional:
npm run cli startCompute did1,did2 algoDid env1

but for eg maxJobDuration is required parameter and paymentToken etc
saw that in the help we have it updated but readme will be nice as well

startCompute [options] <datasetDids> <algoDid> <computeEnvId> <maxJobDuration> <paymentToken> <resources> Starts a compute job

also maybe worth adding some hints from where you can get them from and what maxJobDuration means(seconds, miliseconds etc) where you cand find the paymentToken info (address, symbol what is needed) so users have a better UX.

[mariacarmina]

Looks good overall, but before merge update the readme and command will be useful because for eg we have

Start Compute:

Positional:
npm run cli startCompute did1,did2 algoDid env1

but for eg maxJobDuration is required parameter and paymentToken etc saw that in the help we have it updated but readme will be nice as well

startCompute [options] <datasetDids> <algoDid> <computeEnvId> <maxJobDuration> <paymentToken> <resources> Starts a compute job

also maybe worth adding some hints from where you can get them from and what maxJobDuration means(seconds, miliseconds etc) where you cand find the paymentToken info (address, symbol what is needed) so users have a better UX.

Sure, I can enhance the usage documentation, thanks for suggestion.

[mariacarmina]

Looks good overall, but before merge update the readme and command will be useful because for eg we have

Start Compute:

Positional:
npm run cli startCompute did1,did2 algoDid env1

but for eg maxJobDuration is required parameter and paymentToken etc saw that in the help we have it updated but readme will be nice as well

startCompute [options] <datasetDids> <algoDid> <computeEnvId> <maxJobDuration> <paymentToken> <resources> Starts a compute job

also maybe worth adding some hints from where you can get them from and what maxJobDuration means(seconds, miliseconds etc) where you cand find the paymentToken info (address, symbol what is needed) so users have a better UX.

Hello @bogdanfazakas, I updated the README with details about positional and named fields (how they can be retrieved and what kind of value needs to be set).
The error that you encountered is not a specific log in the code with that message and that message occurs to all commands.

I recommend to have a dedicated issue for this enhancement for all the commands not only for startCompute and merge the current functionality. Please create an issue if the README does not cover the error logging requirements and ref this PR comments there for tracking.
Thank you!