fix no did logs (#1383)

Author: giurgiur99

src/components/core/compute/startCompute.ts

@@ -784,7 +784,7 @@ export class FreeComputeStartHandler extends CommonComputeHandler {
         }
       }
       for (const elem of [...[task.algorithm], ...task.datasets]) {
-        if (!('documentId' in elem)) {
+        if (!('documentId' in elem) || !elem.documentId) {
           continue
         }
         const ddo = await new FindDdoHandler(this.getOceanNode()).findAndFormatDdo(

src/components/core/compute/utils.ts

@@ -23,8 +23,8 @@ export function generateUniqueID(jobStructure: any): string {
 }
 
 export async function getAlgoChecksums(
-  algoDID: string,
-  algoServiceId: string,
+  algoDID: string | undefined,
+  algoServiceId: string | undefined,
   oceanNode: OceanNode,
   config: OceanNodeConfig
 ): Promise<AlgoChecksums> {
@@ -33,6 +33,10 @@ export async function getAlgoChecksums(
     container: '',
     serviceId: algoServiceId
   }
+  // Raw-code algorithms have no DDO to resolve - skip the lookup (no error logs, no DB hit)
+  if (!algoDID) {
+    return checksums
+  }
   try {
     const algoDDO = await new FindDdoHandler(oceanNode).findAndFormatDdo(algoDID)
     if (!algoDDO) {

src/test/unit/compute.test.ts

@@ -38,6 +38,10 @@ import {
 import { checkManifestPlatform } from '../../components/c2d/compute_engine_docker.js'
 import { ValidateParams } from '../../components/httpRoutes/validateCommands.js'
 import { Readable } from 'stream'
+import sinon from 'sinon'
+import { getAlgoChecksums } from '../../components/core/compute/utils.js'
+import { FindDdoHandler } from '../../components/core/handler/ddoHandler.js'
+import { CORE_LOGGER } from '../../utils/logging/common.js'
 
 /* eslint-disable require-await */
 class TestC2DEngine extends C2DEngine {
@@ -517,3 +521,33 @@ describe('Compute Jobs Database', () => {
     await tearDownEnvironment(envOverrides)
   })
 })
+
+describe('getAlgoChecksums', () => {
+  let findDdoStub: sinon.SinonStub
+  let loggerErrorSpy: sinon.SinonSpy
+
+  beforeEach(() => {
+    findDdoStub = sinon.stub(FindDdoHandler.prototype, 'findAndFormatDdo')
+    loggerErrorSpy = sinon.spy(CORE_LOGGER, 'error')
+  })
+
+  afterEach(() => {
+    findDdoStub.restore()
+    loggerErrorSpy.restore()
+  })
+
+  it('returns empty checksums without a DDO lookup for raw-code algorithms (no documentId)', async () => {
+    const checksums = await getAlgoChecksums(
+      undefined,
+      undefined,
+      null as any,
+      null as any
+    )
+
+    expect(checksums).to.deep.equal({ files: '', container: '', serviceId: undefined })
+    // no DDO lookup must be attempted when there is no algorithm documentId
+    expect(findDdoStub.called).to.equal(false)
+    // and therefore no "Algorithm with id: undefined not found!" error is logged
+    expect(loggerErrorSpy.called).to.equal(false)
+  })
+})