Skip to content

Commit 5fe0bc8

Browse files
committed
fix envs overide config
1 parent 14027e9 commit 5fe0bc8

1 file changed

Lines changed: 19 additions & 0 deletions

File tree

src/test/integration/configAdmin.test.ts

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@ describe('Config Admin Endpoints Integration Tests', () => {
2828
let nonAdminAccount: Signer
2929
let previousConfiguration: OverrideEnvConfig[]
3030
let oceanNode: OceanNode
31+
let savedMaxReqPerMinute: string | undefined
32+
let savedMaxConnectionsPerMinute: string | undefined
3133

3234
const mockSupportedNetworks: RPCS = getMockSupportedNetworks()
3335

@@ -53,6 +55,12 @@ describe('Config Admin Endpoints Integration Tests', () => {
5355
)
5456
)
5557

58+
// buildMergedConfig merges env over file; these vars would override pushed rate limits.
59+
savedMaxReqPerMinute = process.env.MAX_REQ_PER_MINUTE
60+
savedMaxConnectionsPerMinute = process.env.MAX_CONNECTIONS_PER_MINUTE
61+
delete process.env.MAX_REQ_PER_MINUTE
62+
delete process.env.MAX_CONNECTIONS_PER_MINUTE
63+
5664
config = await getConfiguration(true)
5765
database = await Database.init(config.dbConfig)
5866
// Force a new singleton so this suite sees env-based config (e.g. ALLOWED_ADMINS);
@@ -70,6 +78,17 @@ describe('Config Admin Endpoints Integration Tests', () => {
7078
})
7179

7280
after(async () => {
81+
if (savedMaxReqPerMinute !== undefined) {
82+
process.env.MAX_REQ_PER_MINUTE = savedMaxReqPerMinute
83+
} else {
84+
delete process.env.MAX_REQ_PER_MINUTE
85+
}
86+
if (savedMaxConnectionsPerMinute !== undefined) {
87+
process.env.MAX_CONNECTIONS_PER_MINUTE = savedMaxConnectionsPerMinute
88+
} else {
89+
delete process.env.MAX_CONNECTIONS_PER_MINUTE
90+
}
91+
await getConfiguration(true)
7392
await tearDownEnvironment(previousConfiguration)
7493
})
7594

0 commit comments

Comments
 (0)