Skip to content

Commit e39025f

Browse files
committed
always create new instances
1 parent 1115d77 commit e39025f

3 files changed

Lines changed: 2 additions & 16 deletions

File tree

src/OceanNode.ts

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -60,16 +60,8 @@ export class OceanNode {
6060
public keyManager?: KeyManager,
6161
public blockchainRegistry?: BlockchainRegistry
6262
) {
63-
if (keyManager) {
64-
this.keyManager = keyManager
65-
} else {
66-
this.keyManager = new KeyManager(config)
67-
}
68-
if (blockchainRegistry) {
69-
this.blockchainRegistry = blockchainRegistry
70-
} else {
71-
this.blockchainRegistry = new BlockchainRegistry(this.keyManager, config)
72-
}
63+
this.keyManager = new KeyManager(config)
64+
this.blockchainRegistry = new BlockchainRegistry(this.keyManager, config)
7365
this.coreHandlers = CoreHandlersRegistry.getInstance(this, true)
7466
this.requestMap = new Map<string, RequestLimiter>()
7567
this.config = config

src/components/core/handler/handler.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ export abstract class BaseHandler implements ICommandHandler {
3636
const node = this.getOceanNode()
3737
const requestMap = node.getRequestMap()
3838
const ratePerMinute = node.getConfig().rateLimit
39-
console.log(ratePerMinute)
4039
const requestTime = new Date().getTime()
4140
let isOK = true
4241

src/test/unit/networking.test.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -148,9 +148,7 @@ describe('Test rate limitations and deny list settings', () => {
148148
]
149149
)
150150
envOverrides = await setupEnvironment(TEST_ENV_CONFIG_FILE, envOverrides)
151-
console.log(envOverrides)
152151
const config = await getConfiguration(true)
153-
console.log(config)
154152
const keyManager = new KeyManager(config)
155153
const p2pNode = new OceanP2P(config, keyManager)
156154
await p2pNode.start()
@@ -182,12 +180,9 @@ describe('Test rate limitations and deny list settings', () => {
182180
expect(rate).to.be.equal(true)
183181
for (let i = 0; i < 4; i++) {
184182
// 4 responses, at least one should be blocked
185-
console.log('Try ' + i)
186183
const rateResp = await statusHandler.checkRateLimit('127.0.0.2')
187184
rateLimitResponses.push(rateResp)
188185
}
189-
console.log('Arr')
190-
console.log(rateLimitResponses)
191186
const filtered = rateLimitResponses.filter((r) => r === false)
192187
expect(filtered.length).to.be.gte(1)
193188
})

0 commit comments

Comments
 (0)