Import v0.0.6 of ddo.js.#898
Merged
giurgiur99 merged 60 commits intomainfrom Apr 17, 2025
Merged
Conversation
Contributor
Author
|
For the moment it is good that metadata state update test is skipped for now, needs to be a short/deprecated DDO class with version = "deprecated" which can be returned by DDOManager. |
mariacarmina
commented
Apr 2, 2025
giurgiur99
requested review from
alexcos20,
bogdanfazakas,
giurgiur99,
jamiehewitt15 and
paulo-ocean
as code owners
mariacarmina
commented
Apr 14, 2025
Contributor
Author
mariacarmina
left a comment
mariacarmina
left a comment
There was a problem hiding this comment.
Some cosmetic adjustments from my side, need to test this PR too.
Thanks!
# Conflicts: # package-lock.json # package.json # src/components/core/compute/initialize.ts # src/components/core/compute/startCompute.ts # src/components/core/utils/feesHandler.ts
mariacarmina
commented
Apr 16, 2025
Contributor
Author
mariacarmina
left a comment
mariacarmina
left a comment
There was a problem hiding this comment.
Much better! 💯 I let the final round of review, after we can merge this!
alexcos20
approved these changes
Apr 17, 2025
# Conflicts: # src/components/Indexer/processor.ts # src/components/core/handler/ddoHandler.ts # src/test/integration/testUtils.ts
bogdanfazakas
approved these changes
Apr 17, 2025
Member
bogdanfazakas
left a comment
bogdanfazakas
left a comment
There was a problem hiding this comment.
looks good, nice job 👍
there are some small question that you can take a look at
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #856 .
Changes proposed in this PR: