Skip to content

Integrate credentials checks in initializeCompute and startCompute handlers#937

Merged
mariacarmina merged 40 commits into
mainfrom
feature/credentials-check-for-compute
Jul 14, 2025
Merged

Integrate credentials checks in initializeCompute and startCompute handlers#937
mariacarmina merged 40 commits into
mainfrom
feature/credentials-check-for-compute

Conversation

@mariacarmina
Copy link
Copy Markdown
Contributor

@mariacarmina mariacarmina commented May 7, 2025 •
edited
Loading

Fixes #936 .

Changes proposed in this PR:

  • Integrate credentials checks for service and asset levels in initializeCompute and startCompute handlers
  • The same checks for credentials for download command will be executed on initializeCompute and startCompute -> won't be customized policy server routes, will reuse download command
  • Added tests

@mariacarmina
Integrate credentials checks for service and asset levels in initiali…
48474eb 
…zeCompute and startCompute handlers. Added tests.
@mariacarmina mariacarmina self-assigned this May 7, 2025
@mariacarmina mariacarmina changed the title Integrate credentials checks for service and asset levels in initializeCompute and startCompute handlers Integrate credentials checks in initializeCompute and startCompute handlers May 7, 2025
@mariacarmina mariacarmina marked this pull request as ready for review May 8, 2025 19:04
@mariacarmina mariacarmina marked this pull request as draft May 12, 2025 14:40
@mariacarmina mariacarmina marked this pull request as ready for review May 12, 2025 18:21
giurgiur99
giurgiur99 reviewed May 19, 2025
View reviewed changes
Comment thread src/@types/commands.ts Outdated
Comment thread src/components/policyServer/index.ts Outdated
Comment thread src/components/core/compute/initialize.ts Outdated
Comment thread src/components/core/compute/initialize.ts Outdated
bogdanfazakas
bogdanfazakas reviewed May 20, 2025
View reviewed changes
Comment thread src/components/core/compute/startCompute.ts Outdated
bogdanfazakas
bogdanfazakas reviewed May 20, 2025
View reviewed changes
Comment thread src/components/core/compute/startCompute.ts Outdated
@giurgiur99
Copy link
Copy Markdown
Contributor

giurgiur99 commented May 30, 2025

Please resolve the conflicts 🙏

giurgiur99
giurgiur99 approved these changes Jun 2, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@giurgiur99 giurgiur99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MBadea17 MBadea17 mentioned this pull request Jul 9, 2025
Closed
@mariacarmina mariacarmina mentioned this pull request Jul 10, 2025
Merged
@mariacarmina mariacarmina merged commit bd12d46 into main Jul 14, 2025
21 of 22 checks passed
@mariacarmina mariacarmina deleted the feature/credentials-check-for-compute branch July 14, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giurgiur99 giurgiur99 giurgiur99 approved these changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

@jamiehewitt15 jamiehewitt15 Awaiting requested review from jamiehewitt15

@paulo-ocean paulo-ocean Awaiting requested review from paulo-ocean

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas is a code owner

Assignees

@mariacarmina mariacarmina

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Compute credentials check

3 participants

@mariacarmina @giurgiur99 @bogdanfazakas