rename to NODE_ENDPOINT, NODE is reserved

Author: giurgiur99

.github/workflows/ci.yml

@@ -100,9 +100,9 @@ jobs:
       matrix:
         include:
           - transport: http
-            node: "http://127.0.0.1:8001"
+            node_endpoint: "http://127.0.0.1:8001"
           - transport: p2p
-            node: "16Uiu2HAmRkJeRYRghP3ETQCpdz8NsQzQE9RpSST7i5YNgWqH4dVE"
+            node_endpoint: "16Uiu2HAmRkJeRYRghP3ETQCpdz8NsQzQE9RpSST7i5YNgWqH4dVE"
 
     steps:
       - uses: actions/checkout@v3
@@ -191,7 +191,7 @@ jobs:
         env:
           INDEXING_RETRY_INTERVAL: 4000
           INDEXING_MAX_RETRIES: 120
-          NODE: ${{ matrix.node }}
+          NODE_ENDPOINT: ${{ matrix.node_endpoint }}
 
       - name: docker logs
         run: |
@@ -216,21 +216,21 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest, macos-latest, windows-latest]
-        node: ["22", "20"]
+        node_endpoint: ["22", "20"]
 
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v4
         with:
-          node-version: ${{ matrix.node }}
+          node-version: ${{ matrix.node_endpoint }}
       - name: Cache node_modules
         uses: actions/cache@v4
         env:
           cache-name: cache-node-modules
         with:
           path: ~/.npm
-          key: ${{ runner.os }}-${{ matrix.node }}-build-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }}
-          restore-keys: ${{ runner.os }}-${{ matrix.node }}-build-${{ env.cache-name }}-
+          key: ${{ runner.os }}-${{ matrix.node_endpoint }}-build-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }}
+          restore-keys: ${{ runner.os }}-${{ matrix.node_endpoint }}-build-${{ env.cache-name }}-
       - run: npm ci
       - run: npm run build
       - run: npm run doc:json

src/config/ConfigHelper.ts

@@ -182,11 +182,10 @@ export const KNOWN_CONFIDENTIAL_EVMS = [
   23295 // oasis_sapphire_testnet
 ]
 
-// keep backward compatible NODE_URL for now
 export const getNodeEndpointConfig = (): Partial<Config> => {
-  if (process.env.NODE || process.env.NODE_URL) {
+  if (process.env.NODE_ENDPOINT || process.env.NODE_URL) {
     return {
-      oceanNodeUri: process.env.NODE || process.env.NODE_URL
+      oceanNodeUri: process.env.NODE_ENDPOINT || process.env.NODE_URL
     }
   }
 

src/services/providers/BaseProvider.ts

@@ -52,9 +52,11 @@ export function getAuthorization(signerOrAuthToken: Signer | string): string | u
   return typeof signerOrAuthToken === 'string' ? signerOrAuthToken : undefined
 }
 
+const MULTIADDR_PREFIXES = ['/ip4/', '/ip6/', '/dns4/', '/dns6/', '/dns/', '/dnsaddr/']
+
 export function isP2pUri(nodeUri: string): boolean {
   if (!nodeUri) return false
-  if (nodeUri.startsWith('/')) return true
+  if (MULTIADDR_PREFIXES.some((p) => nodeUri.startsWith(p))) return true
   try {
     peerIdFromString(nodeUri)
     return true