Drop ->withRealpathRoot().

Author: donquixote

src/ReflectionClassesIA/ReflectionClassesIA_ClassFilesIA.php

@@ -20,7 +20,7 @@ public function __construct(
    * {@inheritdoc}
    */
   public function getIterator(): \Iterator {
-    foreach ($this->classFilesIA->withRealpathRoot() as $file => $class) {
+    foreach ($this->classFilesIA as $file => $class) {
       try {
         $reflectionClass = new ClassReflection($class);
       }
@@ -30,8 +30,19 @@ public function getIterator(): \Iterator {
         // Unfortunately, missing traits still cause fatal error.
         continue;
       }
+      // Skip a class that is defined elsewhere.
+      // Optimize for the case where both paths are already the same, without
+      // calling realpath().
       if ($file !== $reflectionClass->getFileName()) {
-        continue;
+        if ($reflectionClass->getFileName() === false) {
+          // This is a built-in class.
+          continue;
+        }
+        if (realpath($file) !== $reflectionClass->getFileName()
+          && realpath($file) !== realpath($reflectionClass->getFileName())
+        ) {
+          continue;
+        }
       }
       yield $reflectionClass;
     }

tests/src/ReflectionClassesIATest.php

@@ -12,7 +12,6 @@
 use Ock\ClassDiscovery\Tests\Fixtures\Acme\Plant\MusaAcuminata;
 use Ock\ClassDiscovery\Tests\Fixtures\NonLoadingInterface;
 use Ock\ClassFilesIterator\ClassFilesIA\ClassFilesIAInterface;
-use Ock\ClassFilesIterator\ClassFilesIA\RealpathRootThisTrait;
 use Ock\ClassFilesIterator\ClassNamesIA\ClassNamesIAInterface;
 use PHPUnit\Framework\TestCase;
 
@@ -53,9 +52,7 @@ public function testFromClassFilesIA(): void {
       MusaAcuminata::class,
       WaterBear::class,
     ];
-    $classFilesIA = new class($classNames) extends \ArrayObject implements ClassFilesIAInterface {
-      use RealpathRootThisTrait;
-    };
+    $classFilesIA = new class($classNames) extends \ArrayObject implements ClassFilesIAInterface {};
     $reflectionClassesIA = new ReflectionClassesIA_ClassFilesIA($classFilesIA);
     $this->assertReflectionClassNames($expectedRemainingClassNames, $reflectionClassesIA);
   }
@@ -69,9 +66,7 @@ public function testSkipWrongPath(): void {
     $expectedRemainingClassNames = [
       MusaAcuminata::class,
     ];
-    $classFilesIA = new class($classNames) extends \ArrayObject implements ClassFilesIAInterface {
-      use RealpathRootThisTrait;
-    };
+    $classFilesIA = new class($classNames) extends \ArrayObject implements ClassFilesIAInterface {};
     $reflectionClassesIA = new ReflectionClassesIA_ClassFilesIA($classFilesIA);
     $this->assertReflectionClassNames($expectedRemainingClassNames, $reflectionClassesIA);
   }