Remove route_name from recording if it is the same as the id.

Author: donquixote

modules/controller_attributes/tests/recordings/Kernel/ControllerAttributesSnapshotTest/controller_attributes_test.links.action.yml

@@ -2,12 +2,10 @@ module: controller_attributes_test
 type: links.action
 '++ controller_attributes_test.hello_user_overview.add':
   title: 'Add user'
-  route_name: controller_attributes_test.hello_user_overview.add
   appears_on:
     - controller_attributes_test.hello_user_overview.overview
 '++ controller_attributes_test.hello_user_overview.invite':
   title: 'Invite user'
   weight: 10
-  route_name: controller_attributes_test.hello_user_overview.invite
   appears_on:
     - controller_attributes_test.hello_user_overview.overview

modules/controller_attributes/tests/recordings/Kernel/ControllerAttributesSnapshotTest/controller_attributes_test.links.menu.yml

@@ -2,28 +2,22 @@ module: controller_attributes_test
 type: links.menu
 '++ controller_attributes_test.hello.goodbye':
   menu_name: tools
-  route_name: controller_attributes_test.hello.goodbye
   title: Goodbye
   description: 'A farewell greeting'
 '++ controller_attributes_test.hello.hello':
   menu_name: tools
-  route_name: controller_attributes_test.hello.hello
   title: null
 '++ controller_attributes_test.hello_user_overview.overview':
   menu_name: tools
-  route_name: controller_attributes_test.hello_user_overview.overview
   title: 'List of users'
 '++ controller_attributes_test.parent_child.automatic_child':
   menu_name: tools
-  route_name: controller_attributes_test.parent_child.automatic_child
   title: Parent
   parent: controller_attributes_test.parent_child.parent
 '++ controller_attributes_test.parent_child.explicit_child':
   menu_name: tools
-  route_name: controller_attributes_test.parent_child.explicit_child
   title: Parent
   parent: controller_attributes_test.parent_child.parent
 '++ controller_attributes_test.parent_child.parent':
   menu_name: tools
-  route_name: controller_attributes_test.parent_child.parent
   title: Parent

modules/controller_attributes/tests/recordings/Kernel/ControllerAttributesSnapshotTest/controller_attributes_test.links.task.yml

@@ -1,18 +1,14 @@
 module: controller_attributes_test
 type: links.task
 '++ controller_attributes_test.hello_user.delete_user_different_base_route':
-  route_name: controller_attributes_test.hello_user.delete_user_different_base_route
   title: Edit
   base_route: entity.user.canonical
 '++ controller_attributes_test.hello_user.edit':
-  route_name: controller_attributes_test.hello_user.edit
   title: Edit
   base_route: controller_attributes_test.hello_user.view
 '++ controller_attributes_test.hello_user.invite':
-  route_name: controller_attributes_test.hello_user.invite
   title: Invite
   base_route: controller_attributes_test.hello_user.view
 '++ controller_attributes_test.hello_user.view':
-  route_name: controller_attributes_test.hello_user.view
   title: View
   base_route: controller_attributes_test.hello_user.view

modules/ock/modules/ock_preset/tests/recordings/Kernel/OckPresetSnapshotTest/ock_preset.links.action.yml

@@ -2,6 +2,5 @@ module: ock_preset
 type: links.action
 '++ ock_preset.iface_presets.add':
   title: 'Add preset'
-  route_name: ock_preset.iface_presets.add
   appears_on:
     - ock_preset.iface_presets.index

modules/ock/modules/ock_preset/tests/recordings/Kernel/OckPresetSnapshotTest/ock_preset.links.menu.yml

@@ -2,6 +2,5 @@ module: ock_preset
 type: links.menu
 '++ ock_preset.all_presets_overview.index':
   menu_name: tools
-  route_name: ock_preset.all_presets_overview.index
   title: 'ock_preset presets'
   parent: system.admin_structure

modules/ock/modules/ock_preset/tests/recordings/Kernel/OckPresetSnapshotTest/ock_preset.links.task.yml

@@ -1,18 +1,14 @@
 module: ock_preset
 type: links.task
 '++ ock_preset.iface_presets.add':
-  route_name: ock_preset.iface_presets.add
   title: 'Add preset'
   base_route: ock_preset.iface_presets.index
 '++ ock_preset.iface_presets.index':
-  route_name: ock_preset.iface_presets.index
   title: List
   base_route: ock_preset.iface_presets.index
 '++ ock_preset.preset.delete':
-  route_name: ock_preset.preset.delete
   title: Delete
   base_route: ock_preset.preset.edit
 '++ ock_preset.preset.edit':
-  route_name: ock_preset.preset.edit
   title: Edit
   base_route: ock_preset.preset.edit

modules/ock/tests/recordings/Kernel/OckSnapshotTest/ock.links.menu.yml

@@ -2,14 +2,11 @@ module: ock
 type: links.menu
 '++ ock.devel_ops.clear':
   menu_name: devel
-  route_name: ock.devel_ops.clear
   title: 'Rediscover Composition Plugins'
 '++ ock.flush_ock.clear':
   menu_name: admin
-  route_name: ock.flush_ock.clear
   title: 'Flush Ock plugins'
 '++ ock.report_overview.overview':
   menu_name: tools
-  route_name: ock.report_overview.overview
   title: 'ock plugins'
   parent: system.admin_reports

modules/ock/tests/recordings/Kernel/OckSnapshotTest/ock.links.task.yml

@@ -1,30 +1,23 @@
 module: ock
 type: links.task
 '++ ock.report_iface.code':
-  route_name: ock.report_iface.code
   title: Code
   base_route: ock.report_iface.list_of_plugins
 '++ ock.report_iface.demo':
-  route_name: ock.report_iface.demo
   title: Demo
   base_route: ock.report_iface.list_of_plugins
 '++ ock.report_iface.list_of_plugins':
-  route_name: ock.report_iface.list_of_plugins
   title: 'List of plugins'
   base_route: ock.report_iface.list_of_plugins
 '++ ock.report_plugin.code':
-  route_name: ock.report_plugin.code
   title: Code
   base_route: ock.report_plugin.plugin
 '++ ock.report_plugin.demo':
-  route_name: ock.report_plugin.demo
   title: Demo
   base_route: ock.report_plugin.plugin
 '++ ock.report_plugin.devel':
-  route_name: ock.report_plugin.devel
   title: Devel
   base_route: ock.report_plugin.plugin
 '++ ock.report_plugin.plugin':
-  route_name: ock.report_plugin.plugin
   title: Plugin
   base_route: ock.report_plugin.plugin

modules/renderkit/tests/recordings/Kernel/RenderkitSnapshotTest/renderkit.links.menu.yml

@@ -2,11 +2,9 @@ module: renderkit
 type: links.menu
 '++ renderkit.report.demo':
   menu_name: tools
-  route_name: renderkit.report.demo
   title: 'Build provider demo'
   parent: renderkit.report.index
 '++ renderkit.report.index':
   menu_name: tools
-  route_name: renderkit.report.index
   title: Renderkit
   parent: system.admin_reports

packages/drupal-testing/src/Snapshotter/Snapshotter_ActionLinks.php

@@ -14,8 +14,17 @@ class Snapshotter_ActionLinks extends SnapshotterBase {
    * {@inheritdoc}
    */
   protected function getItems(): array {
-    return DrupalTesting::service(LocalActionManagerInterface::class)
+    $definitions = DrupalTesting::service(LocalActionManagerInterface::class)
       ->getDefinitions();
+    foreach ($definitions as $id => $definition) {
+      if (!array_key_exists('route_name', $definition)) {
+        $definitions[$id]['route_name'] = '(missing)';
+      }
+      elseif ($definition['route_name'] === $id) {
+        unset($definitions[$id]['route_name']);
+      }
+    }
+    return $definitions;
   }
 
   /**