HTML API: Remove unused processor state context_node property

gziolo · gziolo · commit 6ed24099457f · 2024-11-27T09:52:21.000Z
The HTML Processor State `context_node` is redundant and can be deprecated. The property has been superseded by `WP_HTML_Processor->context_node` since [58304]. Props jonsurrell, gziolo. Fixes #62518. git-svn-id: https://develop.svn.wordpress.org/trunk@59463 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/src/wp-includes/html-api/class-wp-html-processor-state.php b/src/wp-includes/html-api/class-wp-html-processor-state.php
@@ -360,10 +360,9 @@ class WP_HTML_Processor_State {
 	 * Context node initializing fragment parser, if created as a fragment parser.
 	 *
 	 * @since 6.4.0
+	 * @deprecated 6.8.0 WP_HTML_Processor tracks the context_node internally.
 	 *
-	 * @see https://html.spec.whatwg.org/#concept-frag-parse-context
-	 *
-	 * @var [string, array]|null
+	 * @var null
 	 */
 	public $context_node = null;
 
diff --git a/src/wp-includes/html-api/class-wp-html-processor.php b/src/wp-includes/html-api/class-wp-html-processor.php
@@ -298,7 +298,6 @@ public static function create_fragment( $html, $context = '<body>', $encoding =
 		}
 
 		$processor                             = new static( $html, self::CONSTRUCTOR_UNLOCK_CODE );
-		$processor->state->context_node        = array( 'BODY', array() );
 		$processor->state->insertion_mode      = WP_HTML_Processor_State::INSERTION_MODE_IN_BODY;
 		$processor->state->encoding            = $encoding;
 		$processor->state->encoding_confidence = 'certain';
@@ -317,7 +316,7 @@ public static function create_fragment( $html, $context = '<body>', $encoding =
 
 		$context_node = new WP_HTML_Token(
 			'context-node',
-			$processor->state->context_node[0],
+			'BODY',
 			false
 		);
 
@@ -492,15 +491,6 @@ public function create_fragment_at_current_node( string $html ) {
 		$fragment_processor->context_node->bookmark_name = 'context-node';
 		$fragment_processor->context_node->on_destroy    = null;
 
-		$fragment_processor->state->context_node = array( $fragment_processor->context_node->node_name, array() );
-
-		$attribute_names = $this->get_attribute_names_with_prefix( '' );
-		if ( null !== $attribute_names ) {
-			foreach ( $attribute_names as $name ) {
-				$fragment_processor->state->context_node[1][ $name ] = $this->get_attribute( $name );
-			}
-		}
-
 		$fragment_processor->breadcrumbs = array( 'HTML', $fragment_processor->context_node->node_name );
 
 		if ( 'TEMPLATE' === $fragment_processor->context_node->node_name ) {

Original file line number	Diff line number	Diff line change
`@@ -360,10 +360,9 @@ class WP_HTML_Processor_State {`
`360`	`360`	`* Context node initializing fragment parser, if created as a fragment parser.`
`361`	`361`	`*`
`362`	`362`	`* @since 6.4.0`
	`363`	`+ * @deprecated 6.8.0 WP_HTML_Processor tracks the context_node internally.`
`363`	`364`	`*`
`364`		`- * @see https://html.spec.whatwg.org/#concept-frag-parse-context`
`365`		`- *`
`366`		`- * @var [string, array]\|null`
	`365`	`+ * @var null`
`367`	`366`	`*/`
`368`	`367`	`public $context_node = null;`
`369`	`368`