Remove opam 2.0 support#1054
Open
mtelvers wants to merge 1 commit into
Open
Conversation
The service config pins V2_5 for every build platform and lint.ml uses V2_2; nothing constructs V2_0, so the V2_0 cases in Variant.pp, the opam_build depext match, and Opam_version.of_string were never executed. Variant.pp also drops the V2_0-as-empty-suffix special case, so all variants now print with an explicit _opam-X.X suffix. That in turn makes two more pieces of API redundant: - Opam_version.default -- referenced only by Variant.of_string as a fallback for un-suffixed variant strings. Now that nothing emits un-suffixed strings, of_string rejects them outright. - Opam_version.to_string_with_patch -- declared in the .mli, called nowhere. Prepares for ocurrent/docker-base-images#342 and upstream ocurrent/ocaml-dockerfile#262 to remove the opam-2.0 base images. Deploy-safe in any order: V2_5 platforms pull the same _opam-2.5 tag before and after, and V2_0 was already unused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The service config pins V2_5 for every build platform and lint.ml
uses V2_2; nothing constructs V2_0, so the V2_0 cases in Variant.pp,
the opam_build depext match, and Opam_version.of_string were never
executed.
Variant.pp also drops the V2_0-as-empty-suffix special case, so all
variants now print with an explicit _opam-X.X suffix. That in turn
makes two more pieces of API redundant:
fallback for un-suffixed variant strings. Now that nothing emits
un-suffixed strings, of_string rejects them outright.
nowhere.
Prepares for ocurrent/docker-base-images#342 and upstream
ocurrent/ocaml-dockerfile#262 to remove the opam-2.0 base images.
Deploy-safe in any order: V2_5 platforms pull the same _opam-2.5 tag
before and after, and V2_0 was already unused.