[FIX] mail : fix chatter suggestions position

# How to reproduce
- Go into any form view of a model with a chatter (e.g. Quotation)
- Add multiple long log notes. You need to be able to scroll enough to not see the last log note
- Click edit on the last log note
- Scroll down to the bottom

# The problem
An empty rectangle is displayed next to the log note in edit mode.

# Cause
The rectangle comes from the NavigableList Component, which is the list that displays suggestions when typing things like "@" or "#" :
https://github.com/odoo/odoo/blob/1fd44c3bb11a79d5b6aa72bf7de5a83e6c45be46/addons/mail/static/src/core/common/composer.xml#L137

This components uses the `usePostion()` hook, which purpose is to try to find the
most appropriate place to put the element. It will try different postions (e.g. on the left, below,
above, etc.) and will pick the most appropriate one. It will then adjust the element's style
to position it correctly. It is possible to ask for a preferred position using the options given
to the hook. This position will be prioritized over the others if it is suitable. In the case of
the NavigableList of the chatter, we give it either 'bottom-fit' or the 'top-fit' positions, wich means
it will prefer to be displayed above or below the message :
https://github.com/odoo/odoo/blob/dd84309df7fd39e9e97ed02d135d25b211085135/addons/mail/static/src/core/common/composer.js#L449-L459

But in our case, when we scroll back up, the position of the rectangle stays on the left, even
though the below space is available. That is because of this commit that introduced a
memorization of the last solution :
odoo@b2b8d2d
https://github.com/odoo/odoo/blob/f2434aac74324a65ccd81aa18c7b0e8318e59fde/addons/web/static/src/core/position/position_hook.js#L59-L61

This means that when we scroll down, the bottom positions fails and so the left one
is defaulted to. Since the position is memorized, it stays on the left. The issue with this
left position is that another commit introduced some logic that made it so if the
position is not "top" or "bottom", then we set the element's height to some value :
odoo@702748e
https://github.com/odoo/odoo/blob/f2434aac74324a65ccd81aa18c7b0e8318e59fde/addons/web/static/src/core/position/utils.js#L120-L124

And setting the height of the NavigableList makes it so it displayed even when there are
no suggestions inside, because the hiding mechanism of the suggestion list relies on the
fact that when there are no suggestions, the div is empty and has no height, so it is hidden.

# Propose solution
We introduce a settings in the options that will allow to skip the memorization of
the last position. Since the left position will never be set in the options, no height
will be defined.

opw-6172407

closes odoo#269769

X-original-commit: d6c5dc6
Signed-off-by: Bastien Fafchamps (bafa) <bafa@odoo.com>
Signed-off-by: Zachary Vanvlasselaer (zavan) <zavan@odoo.com>

Author: Zachary (zavan)

addons/mail/static/src/core/common/composer.js

@@ -553,6 +553,7 @@ export class Composer extends Component {
             },
             isLoading: !!searchTerm && loading,
             options: [],
+            rememberPosition: false,
         };
         if (!this.hasSuggestions) {
             return props;

addons/mail/static/src/core/common/navigable_list.js

@@ -24,6 +24,7 @@ export class NavigableList extends Component {
                 options: types.array(types.object()),
                 "optionTemplate?": types.string(),
                 "position?": types.string(),
+                "rememberPosition?": types.boolean(),
             },
             {
                 closeOnSelect: true,
@@ -49,7 +50,7 @@ export class NavigableList extends Component {
             this.close();
         });
         // position and size
-        usePosition("root", () => this.props.anchorRef?.(), { position: this.props.position });
+        usePosition("root", () => this.props.anchorRef?.(), { position: this.props.position, rememberPosition: this.props.rememberPosition });
         useLayoutEffect(
             () => {
                 this.open();

addons/web/static/src/core/position/position_hook.js

@@ -12,6 +12,8 @@ import { EventBus, onWillDestroy } from "@odoo/owl";
  * @property {(popperElement: HTMLElement, solution: PositioningSolution) => void} [onPositioned]
  *  callback called when the positioning is done.
  * @typedef {ComputePositionOptions & UsePositionOptionsExtensionType} UsePositionOptions
+ * @property {boolean} [rememberPosition=true]
+ *  keep the last position as the preferred one
  *
  * @typedef PositioningControl
  * @property {() => void} lock prevents further positioning updates
@@ -42,6 +44,7 @@ export const POSITION_BUS = Symbol("position-bus");
  *  control object to lock/unlock the positioning.
  */
 export function usePosition(popperRef, getTarget, options = {}) {
+    const rememberPosition = options.rememberPosition ?? true;
     // Transitional shim (Owl 2 -> 3): `popperRef` may be either a legacy
     // ref-name string (resolved through `useRef`) or an Owl 3 signal (a
     // function returning the element). Resolve "the current popper element"
@@ -67,7 +70,7 @@ export function usePosition(popperRef, getTarget, options = {}) {
         const repositionOptions = omit(options, "onPositioned");
         const solution = reposition(popperEl, targetEl, repositionOptions);
         // Don't memorize center position because it's a fallback that we don't want to keep if possible
-        if (solution.direction !== "center") {
+        if (rememberPosition && solution.direction !== "center") {
             options.position = `${solution.direction}-${solution.variant}`; // memorize last position
         }
         options.onPositioned?.(popperEl, solution);