[FIX] web: don't open the record when clicking on a binary widget field

If a list view contains a field (column) with binary widget, on click it
will download the content of the field. This is the intended behavior
but at the same time it will, by default, open the record of which it is
part, which is strange since the user only wants to download the
content.

With this PR we make use of .stop on the t-on-click to detach the
execution of the function from the opening of the record.

We also add unit tests for this.

closes odoo#268044

Task: 6260266
X-original-commit: 0231d0a
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

Author: FedericoBraidi

addons/web/static/src/views/fields/binary/binary_field.xml

@@ -15,8 +15,9 @@
                                 class="btn btn-link fa fa-download o_download_file_button"
                                 data-tooltip="Download"
                                 aria-label="Download"
-                                t-on-click="this.onFileDownload"
-                            />
+                                t-on-click.stop="this.onFileDownload"
+                            >
+                            </button>
                         </t>
                         <t t-set-slot="toggler">
                             <span t-if="!this.fileName" class="btn btn-primary o_select_file_button py-0">
@@ -53,7 +54,7 @@
             </t>
         </t>
         <t t-elif="this.props.record.resId and this.props.record.data[this.props.name]">
-            <a class="o_form_uri" href="#" t-on-click.prevent="this.onFileDownload">
+            <a class="o_form_uri" href="#" t-on-click.prevent.stop="this.onFileDownload">
                 <span class="fa fa-download me-2" />
                 <t t-if="this.fileName" t-out="this.fileName" />
             </a>

addons/web/static/tests/views/fields/binary_field.test.js

@@ -528,3 +528,44 @@ test("doesn't crash if value is not a string", async () => {
     });
     expect(".o_field_binary input").toHaveValue("");
 });
+
+test("Binary field in list view doesn't open the record when clicked", async () => {
+    Partner._records[0]["document"] = BINARY_FILE;
+    onRpc("/web/content", async (request) => {
+        expect.step("/web/content");
+        const body = await request.formData();
+        return new Blob([body.get("data")], { type: "text/plain" });
+    });
+    await mountView({
+        resModel: "res.partner",
+        type: "list",
+        arch: `
+            <list>
+                <field name="document" filename="foo" widget="binary"/>
+                <field name="foo"/>
+            </list>
+        `,
+        selectRecord: () => {
+            expect.step("selectRecord");
+        },
+    });
+
+    expect(`.o_data_row .o_data_cell`).toHaveText("coucou.txt");
+    const deferred = new Deferred();
+    const downloadOnClick = (ev) => {
+        const target = ev.target;
+        if (target.tagName === "A" && "download" in target.attributes) {
+            ev.preventDefault();
+            document.removeEventListener("click", downloadOnClick);
+            deferred.resolve();
+        }
+    };
+    document.addEventListener("click", downloadOnClick);
+    after(() => document.removeEventListener("click", downloadOnClick));
+    await contains(".o_field_widget[name='document'] .o_form_uri").click();
+    await deferred;
+    expect.verifySteps(["/web/content"]);
+
+    await contains(`.o_data_row .o_data_cell:eq(1)`).click();
+    expect.verifySteps(["selectRecord"]);
+});