Skip to content

[IMP] spreadsheet: expanding pivot table documentation#17973

Closed
mcsi-odoo wants to merge 1 commit into
19.0from
19.0-spreadsheet-pivot-tables-mcsi
Closed

[IMP] spreadsheet: expanding pivot table documentation#17973
mcsi-odoo wants to merge 1 commit into
19.0from
19.0-spreadsheet-pivot-tables-mcsi

Conversation

@mcsi-odoo

Copy link
Copy Markdown
Contributor

task-6048514

@robodoo

robodoo commented May 18, 2026

Copy link
Copy Markdown
Collaborator

Pull request status dashboard

@C3POdoo C3POdoo requested review from a team May 18, 2026 16:01
@mcsi-odoo mcsi-odoo requested review from xpl-odoo and removed request for a team May 19, 2026 07:08

@xpl-odoo xpl-odoo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @mcsi-odoo! I like the new structure and how the various concepts are explained. You managed to tackle yet another complex topic thoroughly, thanks a lot for this :)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth it to have a separate page just for this? Or could this be moved elsewhere (or removed)?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've flip-flopped on this a lot! I don't want to just squeeze it in somewhere else, especially as I do think it's valuable for users who might be using Spreadsheet / Dashboard for financial reports and dashboards. Audrey was ok with me keeping it, especially with the idea that breaking up content into smaller chunks is in itself not a bad thing. So, unless you feel very strongly, I'd like to keep it (for now, at least).

Comment thread content/applications/productivity/spreadsheet/insert/insert_pivot_table.rst Outdated
Comment thread content/applications/productivity/spreadsheet/insert/insert_pivot_table.rst Outdated
Comment thread content/applications/productivity/spreadsheet/insert/insert_pivot_table.rst Outdated
Comment thread content/applications/productivity/spreadsheet/insert/insert_pivot_table.rst Outdated
Comment thread content/applications/productivity/spreadsheet/work_with_data/pivot_tables.rst Outdated
Comment thread content/applications/productivity/spreadsheet/work_with_data/pivot_tables.rst Outdated
Comment thread content/applications/productivity/spreadsheet/work_with_data/pivot_tables.rst Outdated
Comment thread content/applications/productivity/spreadsheet/work_with_data/pivot_tables.rst Outdated
Comment thread content/applications/productivity/spreadsheet/work_with_data/pivot_tables.rst Outdated

@xpl-odoo xpl-odoo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @mcsi-odoo! I like the new structure and how the various concepts are explained. You managed to tackle yet another complex topic thoroughly, thanks a lot for this :)

@mcsi-odoo mcsi-odoo left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the review, Xavier! And sorry for all the silly errors you had to catch!
I've accepted and resolved most of the comments, and responded to a few to explain my reasoning.
I'll push a new version with the changes.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've flip-flopped on this a lot! I don't want to just squeeze it in somewhere else, especially as I do think it's valuable for users who might be using Spreadsheet / Dashboard for financial reports and dashboards. Audrey was ok with me keeping it, especially with the idea that breaking up content into smaller chunks is in itself not a bad thing. So, unless you feel very strongly, I'd like to keep it (for now, at least).

Comment thread content/applications/productivity/spreadsheet/insert/insert_pivot_table.rst Outdated
Comment thread content/applications/productivity/spreadsheet/insert/insert_pivot_table.rst Outdated
Comment thread content/applications/productivity/spreadsheet/work_with_data/pivot_tables.rst Outdated
Comment thread content/applications/productivity/spreadsheet/work_with_data/pivot_tables.rst Outdated
Comment on lines +130 to +131
To :ref:`prevent real-time updates <spreadsheet/pivot-tables/properties-defer-updates>` while
building or manipulating a pivot table, enable :guilabel:`Defer updates`.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to keep it here since this is an overview of what you see in the properties panel, so it would feel odd to not mention it.

Comment thread content/applications/productivity/spreadsheet/work_with_data/pivot_tables.rst Outdated
To change how a measure is shown:

#. Open the :ref:`pivot table's properties panel <spreadsheet/pivot-tables/properties>`.
#. On the measure's card, click the :icon:`fa-cog` :guilabel:`Show values as` icon.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead, I've updated this to:

Suggested change
#. On the measure's card, click the :icon:`fa-cog` :guilabel:`Show values as` icon.
#. On the measure's card, click :icon:`fa-cog` :guilabel:`(Show values as)`.

Since there is actually a label when you hover over it. Looks ok?

@mcsi-odoo mcsi-odoo force-pushed the 19.0-spreadsheet-pivot-tables-mcsi branch from 0adb93d to cbe6c20 Compare June 3, 2026 07:28
@mcsi-odoo mcsi-odoo requested a review from xpl-odoo June 3, 2026 09:46
@xpl-odoo

xpl-odoo commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Thanks for addressing my suggestions and for providing some context if not ;)

@robodoo r+

robodoo pushed a commit that referenced this pull request Jun 5, 2026
task-6048514

closes #17973

Signed-off-by: Xavier Platteau (xpl) <xpl@odoo.com>
robodoo pushed a commit that referenced this pull request Jun 5, 2026
task-6048514

closes #17973

Signed-off-by: Xavier Platteau (xpl) <xpl@odoo.com>
@robodoo robodoo closed this in 7df9a8a Jun 6, 2026
@mcsi-odoo mcsi-odoo removed the request for review from xpl-odoo June 15, 2026 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants