[ADD] rental: new product types page#17997
Conversation
|
|
|
Hi @stepperpig, this PR is ready for review. |
stepperpig
left a comment
stepperpig
left a comment
There was a problem hiding this comment.
Hi @meval1006, just took a look at your doc! Left mostly suggestions for style and formatting, but there are also comments in places needing clarification. Please make sure to add any missing doc links in seealso sections. I'm approving this since for the most part the changes are minor. After addressing them, this is ready for a final review!
| To view all products available for rent in the database, navigate to Rentals app ‣ Products. By | ||
| default, the Rental filter appears in the search bar, and the view is Kanban. Click the search bar | ||
| and from the preset filters, select Goods, Services, or both. All the selected options appear as | ||
| Kanban cards. For Goods, the card displays the name, rental rate, and amount on hand. For Services, |
There was a problem hiding this comment.
the "amount on hand" depends on if the "track inventory" option is enabled on the product form... if i'm not mistaken. if so, might be worth clarifying that with a few words.
also, please check if any other fields appear based on configurations.
meval1006
force-pushed
the
saas-19.1-rental-new-product-type-page-meval
branch
from
8b92205 to
1ca02a2
Compare
|
Thanks @stepperpig, I think I messed up a git push, because I had to resolve a merge conflict that had all the missing formatting and links. Sorry, you have to review that. Feel free to poke me next time something like this happens, and I will ensure everything is probably formatted for you to check. |
|
Hi @Felicious, this is ready for final review. |
Felicious
left a comment
Felicious
left a comment
There was a problem hiding this comment.
LGTM @meval1006 (:
@robodoo delegate+
Co-authored-by: Felicia Kuan <freakyotaku@gmail.com>
meval1006
force-pushed
the
saas-19.1-rental-new-product-type-page-meval
branch
from
88ce302 to
556d0f9
Compare
|
@robodoo r+ |
closes #17997 Signed-off-by: Megan Valenzuela (meval) <meval@odoo.com> Co-authored-by: Felicia Kuan <freakyotaku@gmail.com>
4 participants
Added the 19.1-2 version of the Product types page for the Configure products subsection of the Rental app.
Changes
Relevant versions
saas-19.1 to saas-19.2