[IMP] pos: add locations to urbanpiper providers#17999
Closed
LoredanaLrpz wants to merge 1 commit into
Closed
Conversation
Collaborator
|
|
LoredanaLrpz
force-pushed
the
19.0-urbanpiper-lrpz
branch
2 times, most recently
from
a63b381 to
c53dc68
Compare
LoredanaLrpz
force-pushed
the
19.0-urbanpiper-lrpz
branch
from
c53dc68 to
bf09918
Compare
Contributor
Author
|
I force-pushed bc there was a conflict with this PR #17413 |
mcsi-odoo
requested changes
Jun 4, 2026
mcsi-odoo
left a comment
mcsi-odoo
left a comment
Contributor
There was a problem hiding this comment.
Hey @LoredanaLrpz , nice job with the tabs and table ... using striped rows really helps when there is so much information. The TL who requested this will surely be happy!
Take a look at my suggestions/questions/comments and see what you think!
| * - `Talabat <https://www.talabat.com>`_ | ||
| - Bahrain, Egypt, Iraq, Jordan, Kuwait, Oman, Qatar, Saudi Arabia, United Arab Emirates | ||
|
|
||
| .. tab:: Regional and national providers: Asia and Oceania |
Contributor
There was a problem hiding this comment.
I think we need to add GrabFood and GoFood, right?
Contributor
Author
There was a problem hiding this comment.
GrabFood and Gofood are integrations, similar to UrbanPiper, they'll have their own page, here's the pull request of the GoFood page, I'm still waiting on the updates from xido :)
LoredanaLrpz
force-pushed
the
19.0-urbanpiper-lrpz
branch
from
bf09918 to
8bc1103
Compare
task-6045375
LoredanaLrpz
force-pushed
the
19.0-urbanpiper-lrpz
branch
from
8bc1103 to
095e0b3
Compare
mcsi-odoo
approved these changes
Jun 9, 2026
mcsi-odoo
left a comment
mcsi-odoo
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Thanks @LoredanaLrpz 💐
@robodoo r+
jacbodoo
pushed a commit
that referenced
this pull request
Jun 9, 2026
task-6045375 closes #17999 Signed-off-by: Siobhan McGonigle (mcsi) <mcsi@odoo.com>
This was referenced Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
task-6045375