[FIX] format: number format with no digit

Since e8b38a a format with no date part and no digit is (correctly)
detected as a number format. But the implementation of a format
with no digit applied to a non-zero number was not correct.
`123` formatted with `[$str]` was formatted as `str123` instead of `str`.

closes #8395

Task: 6068824
X-original-commit: c438eb3
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Signed-off-by: Adrien Minne (adrm) <adrm@odoo.com>

Author: hokolomopo

src/helpers/format/format.ts

@@ -251,10 +251,12 @@ function applyInternalNumberFormat(value: number, format: NumberInternalFormat,
   }
   const { integerDigits, decimalDigits } = splitNumber(Math.abs(value), maxDecimals);
 
+  const hasDigitInDecimalPart = !!format.decimalPart?.some((token) => token.type === "DIGIT");
   let formattedValue = applyIntegerFormat(
     integerDigits,
     format,
-    format.thousandsSeparator ? locale.thousandsSeparator : undefined
+    format.thousandsSeparator ? locale.thousandsSeparator : undefined,
+    hasDigitInDecimalPart
   );
 
   if (format.decimalPart !== undefined) {
@@ -273,10 +275,12 @@ function applyInternalNumberFormat(value: number, format: NumberInternalFormat,
 function applyIntegerFormat(
   integerDigits: string,
   internalFormat: NumberInternalFormat,
-  thousandsSeparator: string | undefined
+  thousandsSeparator: string | undefined,
+  hasDigitInDecimalPart: boolean
 ): string {
   let tokens = internalFormat.integerPart;
-  if (!tokens.some((token) => token.type === "DIGIT")) {
+  // If the format has a decimal part with digits, we always want to display the integer digits
+  if (hasDigitInDecimalPart && !tokens.some((token) => token.type === "DIGIT")) {
     tokens = [...tokens, { type: "DIGIT", value: "#" }];
   }
   if (integerDigits === "0") {

tests/formats/format_helpers.test.ts

@@ -409,6 +409,14 @@ describe("formatValue on number", () => {
     expect(() => formatValue(1234, { format: "# @", locale })).toThrow();
     expect(() => formatValue(1234, { format: "@0", locale })).toThrow();
   });
+
+  test("Format with no digit in them", () => {
+    expect(formatValue(200, { format: "[$Positive]", locale })).toBe("Positive");
+    expect(formatValue(-123, { format: '0;,"Negative"', locale })).toBe("Negative");
+    expect(formatValue(0, { format: '0;0;"Zero"', locale })).toBe("Zero");
+    expect(formatValue("test", { format: '"Smile"', locale })).toBe("test");
+    expect(formatValue("test", { format: '@"Smile"', locale })).toBe("testSmile");
+  });
 });
 
 describe("formatValue on large numbers", () => {