[FIX] format: large number format with no digits

Since e8b38a a format with no date part and no digit is (correctly)
detected as a number format. But `_createLargeNumberFormat` would
crash if there were no digits.

closes #8394

Task: 6010376
X-original-commit: 269bec6
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Signed-off-by: Adrien Minne (adrm) <adrm@odoo.com>

Author: hokolomopo

src/helpers/format/format.ts

@@ -826,7 +826,7 @@ function _createLargeNumberFormat<T extends InternalFormat>(
 
   const lastDigitIndex = newIntegerPart.findLastIndex((token) => token.type === "DIGIT");
   if (lastDigitIndex === -1) {
-    throw new Error("Cannot create a large number format from a format with no digit.");
+    return format;
   }
   while (newIntegerPart[lastDigitIndex + 1]?.type === "THOUSANDS_SEPARATOR") {
     newIntegerPart = removeIndexesFromArray(newIntegerPart, [lastDigitIndex + 1]);

tests/formats/format_helpers.test.ts

@@ -1099,6 +1099,7 @@ describe("rounding format", () => {
   test("Round multi part format", () => {
     expect(roundFormat("0.00\\€;$0.#; 0.00 ;@")).toBe("0\\€;$0; 0 ;@");
     expect(roundFormat("dd/mm/yyyy;0.#")).toBe("dd/mm/yyyy;0");
+    expect(roundFormat(" - ; - ; - ; - ")).toBe(" - ; - ; - ; - ");
   });
 });
 

tests/formats/formatting_plugin.test.ts

@@ -249,6 +249,10 @@ describe("formatting values (with formatters)", () => {
     setFormat(model, "A1", ";;;@");
     setDecimal(model, "A1", -1);
     expect(getCell(model, "A1")?.format).toBe(";;;@");
+
+    setFormat(model, "A1", " - ; - ; - ; - ");
+    setDecimal(model, "A1", -1);
+    expect(getCell(model, "A1")?.format).toBe(" - ; - ; - ; - ");
   });
 
   test("SET_DECIMAL on scientific format", () => {

tests/functions/module_custom.test.ts

@@ -1,6 +1,6 @@
 import { Model } from "../../src";
 import { setCellContent, setCellFormat, setFormat } from "../test_helpers/commands_helpers";
-import { getCellContent, getCellError } from "../test_helpers/getters_helpers";
+import { getCellContent, getCellError, getEvaluatedCell } from "../test_helpers/getters_helpers";
 import { evaluateCellText } from "../test_helpers/helpers";
 
 describe("FORMAT.LARGE.NUMBER formula", () => {
@@ -178,4 +178,12 @@ describe("FORMAT.LARGE.NUMBER formula", () => {
     setCellContent(model, "A2", "=FORMAT.LARGE.NUMBER(A1)");
     expect(getCellContent(model, "A2")).toBe("10,000k%");
   });
+
+  test("FORMAT.LARGE.NUMBER does not crash on format without digits", () => {
+    const model = new Model();
+    setCellContent(model, "A1", "100000");
+    setFormat(model, "A1", " - ; - ; - ; - ");
+    setCellContent(model, "A2", "=FORMAT.LARGE.NUMBER(A1)");
+    expect(getEvaluatedCell(model, "A2")?.format).toBe(" - ; - ; - ; - ");
+  });
 });