Skip to content

[IMP] charts: import/export title colors#8146

Open
anhe-odoo wants to merge 1 commit into
masterfrom
master-xlsx-fix_chart_import-anhe
Open

[IMP] charts: import/export title colors#8146
anhe-odoo wants to merge 1 commit into
masterfrom
master-xlsx-fix_chart_import-anhe

Conversation

@anhe-odoo
Copy link
Copy Markdown
Contributor

Task Description

This PR aims to add the ability to import and export title and axis title color from/to xlsx file

Related Task:

@robodoo
Copy link
Copy Markdown
Collaborator

robodoo commented Mar 20, 2026

Pull request status dashboard

Copy link
Copy Markdown
Contributor

@hokolomopo hokolomopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bunch of nitpicks 🙂

Comment thread src/xlsx/functions/charts.ts
Comment thread tests/xlsx/xlsx_export.test.ts Outdated
Comment on lines +1674 to +1675
const chartTitleSection = content.split("<c:autoTitleDeleted")[0];
expect(chartTitleSection).toContain('val="FF0000"');
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: you could parse the xml (parseXML) and use querySelectors for the tests

Comment thread tests/xlsx/xlsx_import_export.test.ts Outdated
Comment thread tests/xlsx/xlsx_import_export.test.ts Outdated
Comment thread tests/xlsx/xlsx_import_export.test.ts Outdated
Comment thread tests/xlsx/xlsx_import_export.test.ts Outdated
@anhe-odoo anhe-odoo force-pushed the master-xlsx-fix_chart_import-anhe branch 2 times, most recently from 4ecd58f to 1fd0880 Compare April 3, 2026 07:06
@anhe-odoo anhe-odoo force-pushed the master-xlsx-fix_chart_import-anhe branch from 1fd0880 to 47cb7a1 Compare April 13, 2026 10:19
Copy link
Copy Markdown
Collaborator

@rrahir rrahir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'chti rebase required

Comment thread src/xlsx/extraction/chart_extractor.ts Outdated
This PR aims to add the ability to import and export title and axis
title color from/to xlsx file

Related Task:

Task: 4952020
@anhe-odoo anhe-odoo force-pushed the master-xlsx-fix_chart_import-anhe branch from 47cb7a1 to eb6d392 Compare May 5, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants