Skip to content

[FIX] Table side panel: fix closing#8164

Open
matho-odoo wants to merge 2 commits into
masterfrom
master-fix-pin-sidepanel-matho
Open

[FIX] Table side panel: fix closing#8164
matho-odoo wants to merge 2 commits into
masterfrom
master-fix-pin-sidepanel-matho

Conversation

@matho-odoo
Copy link
Copy Markdown
Contributor

The table side panel was closing when selecting a cell without a table, it now stays open until the user explicitly closes it, selects another table or deletes the table.

Task: 6008091

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Copy Markdown
Collaborator

robodoo commented Mar 23, 2026

Pull request status dashboard

@matho-odoo matho-odoo force-pushed the master-fix-pin-sidepanel-matho branch 3 times, most recently from 52a5392 to df90bda Compare April 24, 2026 09:16
Copy link
Copy Markdown
Contributor

@hokolomopo hokolomopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋

Comment thread src/actions/edit_actions.ts Outdated
Comment thread src/components/side_panel/table_panel/table_panel.ts
@matho-odoo matho-odoo force-pushed the master-fix-pin-sidepanel-matho branch 3 times, most recently from 1f633f1 to 89a0336 Compare April 29, 2026 11:13
Before this commit:
When selecting another cell on the grid, the side panel closed if the cell was outside of a table,
or changed if the cell was inside another table.

After this commit:
The side panel stays open until the user explicitly closes it, or deletes the table.

Task: 6008091
@matho-odoo matho-odoo force-pushed the master-fix-pin-sidepanel-matho branch from 89a0336 to 6443364 Compare May 5, 2026 12:25
When a table side panel is open, the table range is now highlighted.
This makes it easier for users to identify the table they are editing,
especially when there are multiple tables in the sheet.

Task: 6008091
@matho-odoo matho-odoo force-pushed the master-fix-pin-sidepanel-matho branch from 6443364 to 427f828 Compare May 5, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants