[FIX] format: large number format with no digits#8198
Closed
hokolomopo wants to merge 1 commit into
Closed
Conversation
Collaborator
|
|
hokolomopo
force-pushed
the
saas-19.1-format-large-number-crash-adrm
branch
from
d36d330 to
d04ffeb
Compare
Since e8b38a a format with no date part and no digit is (correctly) detected as a number format. But `_createLargeNumberFormat` would crash if there were no digits. Task: 6010376
hokolomopo
force-pushed
the
saas-19.1-format-large-number-crash-adrm
branch
from
d04ffeb to
c4fe04f
Compare
robodoo
pushed a commit
that referenced
this pull request
Apr 13, 2026
Since e8b38a a format with no date part and no digit is (correctly) detected as a number format. But `_createLargeNumberFormat` would crash if there were no digits. closes #8198 Task: 6010376 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
This was referenced Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since e8b38a a format with no date part and no digit is (correctly) detected as a number format. But
_createLargeNumberFormatwould crash if there were no digits.Task: 6010376
review checklist