[FIX] format: number format with no digit#8395
Closed
fw-bot wants to merge 1 commit into
Closed
Conversation
Since e8b38a a format with no date part and no digit is (correctly) detected as a number format. But the implementation of a format with no digit applied to a non-zero number was not correct. `123` formatted with `[$str]` was formatted as `str123` instead of `str`. Task: 6068824 X-original-commit: c438eb3
Collaborator
|
|
Collaborator
Author
|
@hokolomopo @LucasLefevre this PR targets master and is the last of the forward-port chain containing: To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Contributor
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Apr 14, 2026
Since e8b38a a format with no date part and no digit is (correctly) detected as a number format. But the implementation of a format with no digit applied to a non-zero number was not correct. `123` formatted with `[$str]` was formatted as `str123` instead of `str`. closes #8395 Task: 6068824 X-original-commit: c438eb3 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com> Signed-off-by: Adrien Minne (adrm) <adrm@odoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since e8b38a a format with no date part and no digit is (correctly) detected as a number format. But the implementation of a format with no digit applied to a non-zero number was not correct.
123formatted with[$str]was formatted asstr123instead ofstr.Task: 6068824
review checklist
Forward-Port-Of: #8203