Skip to content

[IMP] pivots: clarify sorting option for rows#8741

Open
hokolomopo wants to merge 1 commit into
masterfrom
master-pivot-row-sorting-adrm
Open

[IMP] pivots: clarify sorting option for rows#8741
hokolomopo wants to merge 1 commit into
masterfrom
master-pivot-row-sorting-adrm

Conversation

@hokolomopo
Copy link
Copy Markdown
Contributor

@hokolomopo hokolomopo commented May 18, 2026

Description

If a pivot has a sortedColumn (sorted based on the values of this column), editing the sorting order of the rows in the side panel looks like it has no effect.

This commit clarifies it by setting the select to Sorted by measure, and if the user edit it we remove the sorted column.

Task: 6186102

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Copy Markdown
Collaborator

robodoo commented May 18, 2026

Pull request status dashboard

pro-odoo
pro-odoo reviewed May 19, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@pro-odoo pro-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋

Comment thread src/components/spreadsheet/spreadsheet.ts Outdated
Comment thread ...ts/side_panel/pivot/pivot_layout_configurator/pivot_dimension_order/pivot_dimension_order.ts
@hokolomopo
[IMP] pivots: clarify sorting option for rows
1d4b338 
If a pivot has a sortedColumn (sorted based on the values of this
column), editing the sorting order of the rows in the side panel
looks like it has no effect.

This commit clarifies it by setting the select to `Sorted by measure`,
and if the user edit it we remove the sorted column.

Task: 6186102
@hokolomopo hokolomopo force-pushed the master-pivot-row-sorting-adrm branch from 4c81f1a to 1d4b338 Compare May 19, 2026 10:23
@hokolomopo
Copy link
Copy Markdown
Contributor Author

hokolomopo commented May 19, 2026

@robodoo r+

@robodoo
Copy link
Copy Markdown
Collaborator

robodoo commented May 19, 2026

@hokolomopo you can't review+.

@hokolomopo
Copy link
Copy Markdown
Contributor Author

hokolomopo commented May 19, 2026

@hokolomopo you can't review+.

Now I have to find which PR i meant to R+ ....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pro-odoo pro-odoo pro-odoo left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hokolomopo @robodoo @pro-odoo