[IMP] scorecard: make config available for odoo#8750
Closed
fdamhaut wants to merge 2 commits into
Closed
Conversation
Collaborator
|
|
fdamhaut
force-pushed
the
master-scorecard-goToRecord-flda
branch
from
June 1, 2026 09:30
d31e64b to
b444eff
Compare
fdamhaut
force-pushed
the
master-scorecard-goToRecord-flda
branch
from
June 11, 2026 13:52
b444eff to
cc4ed31
Compare
| // If the xc is representing a zone, return the zone's top left position instead. | ||
| // If the xc is malformed, this will throw an error. | ||
| // If the sheetName does not exist, it will return undefined. | ||
| export function cellPositionFromXC(getters: Getters, xc: string) { |
Collaborator
There was a problem hiding this comment.
could you use getters.getRangeFromSheetXC() instead of introducing yet another helper parsing references?
fdamhaut
force-pushed
the
master-scorecard-goToRecord-flda
branch
from
June 15, 2026 08:18
cc4ed31 to
2ea00bd
Compare
fdamhaut
force-pushed
the
master-scorecard-goToRecord-flda
branch
from
June 30, 2026 10:57
2ea00bd to
46915e4
Compare
rrahir
force-pushed
the
master-scorecard-goToRecord-flda
branch
from
July 6, 2026 09:04
46915e4 to
eefdfb2
Compare
Collaborator
|
robodoo rebase-ff |
Collaborator
|
Merge method set to rebase and fast-forward. |
Task: 6167643
rrahir
reviewed
Jul 8, 2026
| strikethrough: boolean | undefined = false, | ||
| strokeWidth: number = getContextFontSize(context.font) / 10 //This value is defined to get a good looking stroke | ||
| strokeWidth: number = getContextFontSize(context.font) / 10, //This value is defined to get a good looking stroke | ||
| highlight: boolean | undefined = false |
Collaborator
There was a problem hiding this comment.
Suggested change
| highlight: boolean | undefined = false | |
| highlightText: boolean | undefined = false |
nitpick
Allow the highlighting of text based on the chart runtime Task: 6167643
fdamhaut
force-pushed
the
master-scorecard-goToRecord-flda
branch
from
July 9, 2026 08:01
eefdfb2 to
a31d9a7
Compare
Collaborator
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Jul 9, 2026
Task: 6167643 Part-of: #8750 Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Jul 9, 2026
Allow the highlighting of text based on the chart runtime closes #8750 Task: 6167643 Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task: 6167643
Description:
description of this task, what is implemented and why it is implemented that way.
Task: 6167643
review checklist