[FIX] formulas: add IFERROR second argument when exporting data#8768
Open
fw-bot wants to merge 1 commit into
Open
[FIX] formulas: add IFERROR second argument when exporting data#8768fw-bot wants to merge 1 commit into
fw-bot wants to merge 1 commit into
Conversation
Description In our implementation of the IFERROR formula, the second argument (value if error) is optionnal, defaulting to an empty string, which results to a 0 value in the cell when evaluated. In the excel documentation, the second argument of IFERROR is required leading to issue when exporting from spreadsheet a formula with IFERROR and then importing it to excel or Gsheet. This PR fixes this issue by adding a second argument whenn needed in the exporting process. Related Task Task: 5993405 X-original-commit: 57e3404
Collaborator
|
|
Collaborator
Author
Collaborator
|
@anhe-odoo careful, don't r+ it before owl3 is merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In our implementation of the IFERROR formula, the second argument (value if error) is optionnal, defaulting to an empty string, which results to a 0 value in the cell when evaluated. In the excel documentation, the second argument of IFERROR is required leading to issue when exporting from spreadsheet a formula with IFERROR and then importing it to excel or Gsheet. This PR fixes this issue by adding a second argument whenn needed in the exporting process.
Related Task
Task: 5993405
review checklist
Forward-Port-Of: #8756