[IMP] test diagnostics update on additional_languages config change

This commits factors out the config update handling logic from
`Odoo::check_handle_config_file_update` into a dedicated
`Odoo::handle_config_update`.

This has two benefits:
- better separation of concerns (one handles the config **file** update,
while the other handles the replacement of the current config with a new
ConfigEntry)
- it allows for easier testing of config updates without needing to go
through the file update logic

Based on this, this commit introduces a test for checking whether the
OLS05058 diagnostic (unknown language code) is refreshed correctly when
the additional_languages config is updated.

Author: cammarosano

server/src/core/odoo.rs

@@ -2068,22 +2068,7 @@ impl Odoo {
 
             match config_result {
                 Ok((new_config, cfg_file)) => {
-                    if config::needs_restart(&session.sync_odoo.config, &new_config) {
-                        // Changes require a restart, ask the client to restart the server
-                        session.send_notification("$Odoo/restartNeeded", ());
-                    } else {
-                        // Changes can be applied without restart
-                        let languages_changed = session.sync_odoo.config.additional_languages != new_config.additional_languages;
-                        session.sync_odoo.config_file = Some(cfg_file);
-                        session.sync_odoo.config = new_config;
-                        // Recalculate diagnostic filters
-                        session.sync_odoo.get_file_mgr().borrow_mut().update_all_file_diagnostic_filters(session);
-                        session.update_delay_thread_delay_duration(session.sync_odoo.config.auto_refresh_delay);
-                        if languages_changed {
-                            session.sync_odoo.revalidate_language_dependents();
-                            SyncOdoo::process_rebuilds(session, false);
-                        }
-                    }
+                    Odoo::handle_config_update(session, new_config, cfg_file);
                 }
                 Err(err) => {
                     // Invalid config, send a notification to the user and add the error to the logs
@@ -2099,4 +2084,22 @@ impl Odoo {
         }
     }
 
+    pub fn handle_config_update(session: &mut SessionInfo, new_config: ConfigEntry, cfg_file: ConfigFile) {
+        if config::needs_restart(&session.sync_odoo.config, &new_config) {
+            // Changes require a restart, ask the client to restart the server
+            session.send_notification("$Odoo/restartNeeded", ());
+            return;
+        }
+        // Changes can be applied without restart
+        let languages_changed = session.sync_odoo.config.additional_languages != new_config.additional_languages;
+        session.sync_odoo.config_file = Some(cfg_file);
+        // Recalculate diagnostic filters
+        session.sync_odoo.config = new_config;
+        session.sync_odoo.get_file_mgr().borrow_mut().update_all_file_diagnostic_filters(session);
+        session.update_delay_thread_delay_duration(session.sync_odoo.config.auto_refresh_delay);
+        if languages_changed {
+            session.sync_odoo.revalidate_language_dependents();
+            SyncOdoo::process_rebuilds(session, false);
+        }
+    }
 }

server/tests/test_language_updates.rs

@@ -1,7 +1,8 @@
-use std::collections::HashSet;
+use std::collections::{HashMap, HashSet};
 use std::path::PathBuf;
 
 use lsp_types::{TextDocumentContentChangeEvent, VersionedTextDocumentIdentifier};
+use odoo_ls_server::core::config::ConfigFile;
 use odoo_ls_server::core::file_mgr::FileMgr;
 use odoo_ls_server::core::odoo::Odoo;
 use odoo_ls_server::threads::SessionInfo;
@@ -231,3 +232,59 @@ fn test_additional_languages_config() {
         languages
     );
 }
+
+/// Test that changing additional_languages via config update clears/restores OLS05058 diagnostics.
+#[test]
+fn test_config_additional_languages_updates_diagnostics() {
+    let (mut odoo, config) = setup_server(true);
+    let mut session = create_init_session(&mut odoo, config);
+
+    let items_xml_path = PathBuf::from(env!("CARGO_MANIFEST_DIR"))
+        .join("tests/data/addons/module_lang_test/data/lang_test_items.xml")
+        .sanitize();
+
+    let file_mgr = session.sync_odoo.get_file_mgr();
+    let file_info = file_mgr.borrow().get_file_info(&items_xml_path).unwrap();
+    let force_republish_diagnostic = |session: &mut SessionInfo| {
+        let mut file_info_borrow = file_info.borrow_mut();
+        // This does not rebuild validation steps. It just sets need_push to true.
+        file_info_borrow.update_validation_diagnostics(HashMap::new());
+        file_info_borrow.publish_diagnostics(session);
+    };
+
+    // Verify OLS05058 is present initially (nl_WV is unknown)
+    let diagnostics = get_diagnostics_for_path(&mut session, &items_xml_path);
+    assert!(
+        has_diagnostic_code(&diagnostics, "OLS05058"),
+        "Initial: OLS05058 should be present for nl_WV. Diagnostics: {:?}",
+        diagnostics
+    );
+
+    // Add nl_WV and nl to additional_languages via config update
+    let mut new_config = session.sync_odoo.config.clone();
+    new_config.additional_languages = HashSet::from(["nl_WV".to_string(), "nl".to_string()]);
+    Odoo::handle_config_update(&mut session, new_config, ConfigFile::new());
+
+    // OLS05058 should be gone now
+    // We need to force republish diagnostics to avoid a false negative, as the
+    // previous check consumes the messages.
+    force_republish_diagnostic(&mut session);
+    let diagnostics = get_diagnostics_for_path(&mut session, &items_xml_path);
+    assert!(
+        !has_diagnostic_code(&diagnostics, "OLS05058"),
+        "After adding nl_WV to additional_languages: OLS05058 should be CLEARED. Diagnostics: {:?}",
+        diagnostics
+    );
+
+    // Restore original config (without nl_WV) and verify diagnostic reappears
+    let mut restored_config = session.sync_odoo.config.clone();
+    restored_config.additional_languages = HashSet::new();
+    Odoo::handle_config_update(&mut session, restored_config, ConfigFile::new());
+
+    let diagnostics = get_diagnostics_for_path(&mut session, &items_xml_path);
+    assert!(
+        has_diagnostic_code(&diagnostics, "OLS05058"),
+        "After removing nl_WV from additional_languages: OLS05058 should REAPPEAR. Diagnostics: {:?}",
+        diagnostics
+    );
+}