[IMP] runbot: make params version_id optionnal

Author: Xavier-Do

runbot/models/batch.py

@@ -384,7 +384,7 @@ def _fill_missing(branch_commits, match_type):
                 self._warning(f'This batch will use base commits instead of bundle commits for trigger {trigger.name}')
                 trigger_commit_link_by_repos = base_commit_link_by_repos
             commits_links = [trigger_commit_link_by_repos[repo.id].id for repo in trigger_repos]
-            version_id = bundle_version_id if trigger.version_dependent else False
+            version_id = bundle_version_id if (trigger.version_dependent or trigger.batch_dependent) else False
             params_value = {
                 'version_id':  version_id,
                 'extra_params': extra_params,

runbot/models/build.py

@@ -70,7 +70,7 @@ class BuildParameters(models.Model):
     # execution parametter
     commit_link_ids = fields.Many2many('runbot.commit.link', copy=True)
     commit_ids = fields.Many2many('runbot.commit', compute='_compute_commit_ids')
-    version_id = fields.Many2one('runbot.version', required=True, index=True)
+    version_id = fields.Many2one('runbot.version', index=True)
     project_id = fields.Many2one('runbot.project', required=True, index=True)  # for access rights
     trigger_id = fields.Many2one('runbot.trigger', index=True)  # for access rights
     create_batch_id = fields.Many2one('runbot.batch', index=True)
@@ -534,7 +534,7 @@ def _result_multi(self):
     def _compute_dest(self):
         for build in self:
             if build.id:
-                nickname = build.params_id.version_id.name
+                nickname = build.params_id.version_id.name or 'build'
                 nickname = re.sub(r'"|\'|~|\:', '', nickname)
                 nickname = re.sub(r'_|/|\.', '-', nickname)
                 build.dest = ("%05d-%s" % (build.id or 0, nickname[:32])).lower()