[IMP] util.hr_payroll: ensure salary rule neutralization on removal

Author: romaincarlier4

src/util/hr_payroll.py

@@ -7,6 +7,22 @@
 _logger = logging.getLogger(__name__)
 
 
+def _neutralize_rule(cr, xmlid):
+    rid = ref(cr, xmlid)
+    cr.execute(
+        """
+        UPDATE hr_salary_rule
+           SET condition_select = 'python',
+               condition_python = 'result = False',
+               amount_select = 'fix',
+               amount_fix = 0.0
+         WHERE id = %s
+    """,
+        [rid],
+    )
+    delete_unused(cr, xmlid, deactivate=True)
+
+
 def _remove_salary_rule(cr, xmlid):
     rid = ref(cr, xmlid)
     cr.execute(
@@ -40,12 +56,12 @@ def _remove_salary_rule(cr, xmlid):
             xmlid,
         )
         remove_field(cr, "hr.payroll.report", fname)
-    delete_unused(cr, xmlid, deactivate=True)
+    _neutralize_rule(cr, xmlid)
 
 
 if not version_between("16.0", "saas~18.4"):
 
     def remove_salary_rule(cr, xmlid):
-        delete_unused(cr, xmlid, deactivate=True)
+        _neutralize_rule(cr, xmlid)
 else:
     remove_salary_rule = _remove_salary_rule