Skip to content

[IMP] spreadsheet: support array literals in formula tokenizer#357

Closed
laa-odoo wants to merge 1 commit into
odoo:masterfrom
odoo-dev:master-spreadsheet-support-literal-array-in-tokenizer-laa
Closed

[IMP] spreadsheet: support array literals in formula tokenizer#357
laa-odoo wants to merge 1 commit into
odoo:masterfrom
odoo-dev:master-spreadsheet-support-literal-array-in-tokenizer-laa

Conversation

@laa-odoo
Copy link
Copy Markdown
Contributor

The tokenizer now recognizes array literals (e.g. {1,2;3,4}) by handling braces and array row separators.
This allows formulas using array literals to be properly tokenized.

Task: https://www.odoo.com/odoo/2328/tasks/4735250

@robodoo
Copy link
Copy Markdown
Contributor

robodoo commented Nov 25, 2025

Pull request status dashboard

@laa-odoo laa-odoo force-pushed the master-spreadsheet-support-literal-array-in-tokenizer-laa branch 2 times, most recently from c2bff77 to 85133f0 Compare November 25, 2025 13:49
Comment thread src/spreadsheet/tests/test_spreadsheet_tokenizer.py
Comment thread src/util/spreadsheet/tokenizer.py Outdated
@laa-odoo laa-odoo force-pushed the master-spreadsheet-support-literal-array-in-tokenizer-laa branch 2 times, most recently from ef81a9b to f5db89e Compare December 1, 2025 10:05
@rrahir
Copy link
Copy Markdown

rrahir commented Jan 7, 2026

@anhe-odoo @laa-odoo bump?

@laa-odoo laa-odoo force-pushed the master-spreadsheet-support-literal-array-in-tokenizer-laa branch from f5db89e to 04dda35 Compare January 8, 2026 09:03
@laa-odoo
Copy link
Copy Markdown
Contributor Author

laa-odoo commented Jan 8, 2026

Hello @odoo/upgrade team
It seems that upgradeci/matt is still showing as red,

is this important here ?
thx

@aj-fuentes
Copy link
Copy Markdown
Contributor

You can ignore the missing module error in older versions.

@laa-odoo
Copy link
Copy Markdown
Contributor Author

laa-odoo commented Jan 9, 2026

@rrahir,
I think it should be okay

@rrahir rrahir requested review from a team and Pirols January 9, 2026 08:31
Comment thread src/util/spreadsheet/tokenizer.py Outdated
@laa-odoo laa-odoo force-pushed the master-spreadsheet-support-literal-array-in-tokenizer-laa branch from 04dda35 to 3a02b43 Compare January 9, 2026 09:26
@rrahir
Copy link
Copy Markdown

rrahir commented Jan 9, 2026

@KangOl couldyou have another look? :-)

@rrahir rrahir requested a review from a team January 30, 2026 09:10
@rrahir
Copy link
Copy Markdown

rrahir commented Feb 5, 2026

@KangOl the PR I mentioned during lunch ^^

@KangOl KangOl force-pushed the master-spreadsheet-support-literal-array-in-tokenizer-laa branch from 3a02b43 to e9c9b1d Compare February 5, 2026 13:37
@rrahir
Copy link
Copy Markdown

rrahir commented May 6, 2026

@laa-odoo I forgot about this one, apparently I cannot update it, github rejects my push -f.

@KangOl don't really know what was the error when you rebased the last time, just a missing module for older versions?

The tokenizer now recognizes array literals (e.g. {1,2;3,4})
by handling braces and array row separators.
This allows formulas using array literals to be properly tokenized.

Task: 4735250
@KangOl KangOl force-pushed the master-spreadsheet-support-literal-array-in-tokenizer-laa branch from e9c9b1d to 7662e7a Compare May 6, 2026 13:36
Copy link
Copy Markdown
Contributor

@KangOl KangOl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants