[IMP] util.hr_payroll: ensure salary rule neutralization on removal#405
Closed
romaincarlier4 wants to merge 1 commit into
Closed
[IMP] util.hr_payroll: ensure salary rule neutralization on removal#405romaincarlier4 wants to merge 1 commit into
romaincarlier4 wants to merge 1 commit into
Conversation
Contributor
|
|
romaincarlier4
force-pushed
the
master-neutralize-salary-rule-romc
branch
3 times, most recently
from
4917092 to
12edea4
Compare
romaincarlier4
force-pushed
the
master-neutralize-salary-rule-romc
branch
3 times, most recently
from
508cac6 to
91ae5b1
Compare
KangOl
requested changes
Apr 10, 2026
Contributor
KangOl
left a comment
KangOl
left a comment
There was a problem hiding this comment.
Can you also change the commit message and explain why you do that change?
When a salary rule is explicitely removed, it should never be used again or it will break the computation of future payslips. To ensure that, the salary rule is set to always compute a result of 0. Archiving the rule *should* be sufficient, this is only an extra layer of safety for payroll compliance.
romaincarlier4
force-pushed
the
master-neutralize-salary-rule-romc
branch
from
91ae5b1 to
c85d71f
Compare
KangOl
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.