fix(research): gate trigger_research behind the web-search toggle#5571
Open
Ninthkitten wants to merge 1 commit into
Open
fix(research): gate trigger_research behind the web-search toggle#5571Ninthkitten wants to merge 1 commit into
Ninthkitten wants to merge 1 commit into
Conversation
With web search toggled off, a research request still launched a full deep-research run: the toggle only disabled web_search/web_fetch, and trigger_research was not counted as a web tool. Gate it with the same switch. Fixes odysseus-dev#5527. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With web search toggled off (the per-turn globe toggle in the chat input row), a research request still launched a full deep-research run. The toggle only disabled
web_search/web_fetch—trigger_researchwas not counted as a web tool, so a model could reach the internet through the research path while the UI said web was off. This PR gatestrigger_researchwith the same per-turn web toggle as the other web tools, everywhere that toggle opens or closes web access, so "web off" means offline.Target branch
dev, notmain.Linked Issue
Fixes #5527
Type of Change
Checklist
devdocker compose up) and verified the change works end-to-end. Type-checks and unit tests are not enough.How to Test
TRIGGER_RESEARCHrun launches despite web being off.This fix has been running in a self-hosted deployment since 12 July and is verified in daily use.
🤖 Generated with Claude Code