Skip to content

fix(research): gate trigger_research behind the web-search toggle#5571

Open
Ninthkitten wants to merge 1 commit into
odysseus-dev:devfrom
Ninthkitten:pr/gate-trigger-research-web-toggle
Open

fix(research): gate trigger_research behind the web-search toggle#5571
Ninthkitten wants to merge 1 commit into
odysseus-dev:devfrom
Ninthkitten:pr/gate-trigger-research-web-toggle

Conversation

@Ninthkitten

@Ninthkitten Ninthkitten commented Jul 16, 2026

Copy link
Copy Markdown

Summary

With web search toggled off (the per-turn globe toggle in the chat input row), a research request still launched a full deep-research run. The toggle only disabled web_search/web_fetchtrigger_research was not counted as a web tool, so a model could reach the internet through the research path while the UI said web was off. This PR gates trigger_research with the same per-turn web toggle as the other web tools, everywhere that toggle opens or closes web access, so "web off" means offline.

Target branch

  • This PR targets dev, not main.

Linked Issue

Fixes #5527

Type of Change

  • Bug fix (non-breaking — fixes a confirmed issue)

Checklist

  • I searched open issues and open PRs — this is not a duplicate.
  • This PR targets dev
  • My changes are limited to the scope described above — no unrelated refactors or whitespace changes mixed in.
  • I actually ran the app (docker compose up) and verified the change works end-to-end. Type-checks and unit tests are not enough.

How to Test

  1. Run the app, open a chat, and toggle web search OFF (globe icon in the chat input row).
  2. Ask the model to research something ("do a deep research run on X").
  3. Without this patch, a TRIGGER_RESEARCH run launches despite web being off.
  4. With this patch, research is unavailable while the toggle is off; toggle web back ON and research works as before.

This fix has been running in a self-hosted deployment since 12 July and is verified in daily use.

🤖 Generated with Claude Code

With web search toggled off, a research request still launched a full deep-research run: the toggle only disabled web_search/web_fetch, and trigger_research was not counted as a web tool. Gate it with the same switch. Fixes odysseus-dev#5527.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions github-actions Bot added needs work PR description incomplete — please update before review ready for review Description complete — ready for maintainer review and removed needs work PR description incomplete — please update before review labels Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review Description complete — ready for maintainer review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Agent bypasses "web search off" via trigger_research — research tool is not treated as a web tool

1 participant