Commit c075a82
committed
</think>
fix: remove null checks that cause NPE in admin validator
The validation logic was incorrectly checking for null values after
calling getter methods, which would cause NullPointerException when the
fields were actually null. The null checks have been removed to properly
validate that required fields are present and not empty.
Also streamline release workflow to use shadowJAR and combine build steps
for more efficient artifact creation.1 parent c477da4 commit c075a82
2 files changed
Lines changed: 14 additions & 17 deletions
File tree
- .github/workflows
- src/main/java/com/orisunlabs/orisun/client
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
| 65 | + | |
| 66 | + | |
73 | 67 | | |
74 | 68 | | |
75 | 69 | | |
76 | 70 | | |
77 | 71 | | |
78 | 72 | | |
79 | | - | |
80 | | - | |
| 73 | + | |
| 74 | + | |
81 | 75 | | |
82 | | - | |
83 | | - | |
| 76 | + | |
| 77 | + | |
84 | 78 | | |
85 | 79 | | |
86 | 80 | | |
87 | 81 | | |
88 | | - | |
89 | | - | |
| 82 | + | |
| 83 | + | |
90 | 84 | | |
91 | 85 | | |
92 | 86 | | |
| |||
Lines changed: 6 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
| 22 | + | |
22 | 23 | | |
23 | 24 | | |
24 | 25 | | |
25 | 26 | | |
26 | | - | |
| 27 | + | |
| 28 | + | |
27 | 29 | | |
28 | 30 | | |
29 | 31 | | |
30 | 32 | | |
31 | | - | |
| 33 | + | |
| 34 | + | |
32 | 35 | | |
33 | 36 | | |
34 | 37 | | |
| |||
0 commit comments