Merge pull request #30 from off-grid-ai/fix/no-memory-waiting-label

fix(chat): no-memory chat no longer says "Searching your memory…"

Author: alichherawalla

e2e/screenshots/provit-no-memory-loader.png

@@ -1,5 +1,6 @@
 import { useCallback, useEffect, useRef, useState } from 'react';
 import { shouldQueue, enqueue, dequeue, queuedCount } from '@renderer/lib/chat-queue';
+import { waitingLabel } from '@renderer/lib/chat-labels';
 import ReactMarkdown, { Components } from 'react-markdown';
 import remarkGfm from 'remark-gfm';
 import remarkBreaks from 'remark-breaks';
@@ -1940,7 +1941,7 @@ export function MemoryChat({ onNavigateToMemory, onNavigateToChat, onNavigateToE
                           <span className="h-1.5 w-1.5 animate-bounce rounded-full bg-green-500 [animation-delay:150ms]" />
                           <span className="h-1.5 w-1.5 animate-bounce rounded-full bg-green-500 [animation-delay:300ms]" />
                         </span>
-                        <span className="text-xs text-neutral-500">Searching your memory…</span>
+                        <span className="text-xs text-neutral-500">{waitingLabel({ noMemory, hasProject: !!activeProjectId })}</span>
                       </div>
                     )}
                   </div>

e2e/screenshots/provit-no-memory-scope.png

@@ -0,0 +1,19 @@
+import { describe, it, expect } from 'vitest';
+import { waitingLabel } from '../chat-labels';
+
+describe('waitingLabel — scope-aware "working…" text', () => {
+  it('No-memory (plain chat) must NOT claim to search memory', () => {
+    const label = waitingLabel({ noMemory: true, hasProject: false });
+    expect(label).toBe('Thinking…');
+    expect(label.toLowerCase()).not.toContain('memory'); // the reported bug
+  });
+
+  it('All-memory searches your memory', () => {
+    expect(waitingLabel({ noMemory: false, hasProject: false })).toBe('Searching your memory…');
+  });
+
+  it('a project scopes the search to the project (regardless of noMemory)', () => {
+    expect(waitingLabel({ noMemory: false, hasProject: true })).toBe('Searching this project…');
+    expect(waitingLabel({ noMemory: true, hasProject: true })).toBe('Searching this project…');
+  });
+});

src/renderer/src/components/MemoryChat.tsx

@@ -0,0 +1,17 @@
+// The "working…" label shown while a chat turn is generating, before the first
+// token lands. It MUST reflect the chat's memory scope: a plain (no-memory) chat
+// never touches memory, so it must not claim to be "Searching your memory".
+// Pure + UI-free so it's unit-testable.
+
+export interface ChatScope {
+  /** A project is active → retrieval is scoped to that project. */
+  hasProject: boolean;
+  /** No-memory ("plain chat") mode — no retrieval at all. */
+  noMemory: boolean;
+}
+
+export function waitingLabel(scope: ChatScope): string {
+  if (scope.hasProject) return 'Searching this project…';
+  if (scope.noMemory) return 'Thinking…';
+  return 'Searching your memory…';
+}