Skip to content

Commit 6c28538

Browse files
committed
more assert
1 parent 868051c commit 6c28538

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/hotspot/cpu/s390/sharedRuntime_s390.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2205,6 +2205,7 @@ nmethod *SharedRuntime::generate_native_wrapper(MacroAssembler *masm,
22052205
// Load the oop for the object or class. R_carg2_classorobject contains
22062206
// either the handlized oop from the incoming arguments or the handlized
22072207
// class mirror (if the method is static).
2208+
// TODO: r_oop is not going be changed, so why are we loading it again and again.
22082209
__ z_lg(r_oop, 0, Z_ARG2);
22092210

22102211
lock_offset = (lock_slot_offset * VMRegImpl::stack_slot_size);
@@ -2234,6 +2235,8 @@ nmethod *SharedRuntime::generate_native_wrapper(MacroAssembler *masm,
22342235
__ z_lgr(Z_ARG3, Z_thread);
22352236

22362237
__ set_last_Java_frame(oldSP, Z_R10 /* gc map pc */);
2238+
// TODO: maybe rename Z_R10 to r_java_pc ?
2239+
assert(Z_R10->is_nonvolatile(), "Z_R10 needs to be preserved accross complete_monitor_locking_C call");
22372240

22382241
// TODO: https://bugs.openjdk.org/browse/JDK-8338383
22392242
// Do the call.

0 commit comments

Comments
 (0)