prov/efa: Evaluate p2p support lazily#12311
Open
mthyoung-amzn wants to merge 2 commits into
Open
Conversation
We will be removing the eager check for p2p support to run on lazily on the first attempt to register device memory. We still only want to run the check once, so need to indicate whether we have yet probed for support. This just defines the enum and code that looked at p2p_supported_by_device, no actual change in behavior. Signed-off-by: Mitchell Young <mthyoung@amazon.com>
mthyoung-amzn
force-pushed
the
lazy-p2p-check-2
branch
from
6f3ead6 to
104ab86
Compare
Determination of support for P2P registration of device memory with the NIC was being done eagerly in the EFA_INI path, which is expensive and disruptive. This moves the check for P2P support later, on the first attempt to register a device buffer with ibv. If this fails, we latch support for p2p to UNSUPPORTED and fall through to the fallback mechanism that uses bounce buffer. Future attempts to register a device buffer will go directly to the fallback mechanism. Signed-off-by: Mitchell Young <mthyoung@amazon.com>
mthyoung-amzn
force-pushed
the
lazy-p2p-check-2
branch
from
104ab86 to
0ee735b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.