Commit 3cbfbde
committed
deps: pin yosys 0.63 + carry bazel-orfs BLOCKS shared-block.mk patch
Two coupled MODULE.bazel changes:
1. single_version_override(yosys = "0.63"). bazel-orfs pins
yosys 0.62.bcr.2, which has a KOGGE_STONE / BRENT_KUNG IdString
memory-safety bug that crashes synth on a few asap7 designs.
0.63 is on canonical BCR; drop this override once bazel-orfs itself
bumps to 0.63.
2. git_override(patches = [.../0001-blocks-shared-blockmk.patch]) on
the bazel-orfs dep. bazel-orfs's BLOCKS handling only walks
per-block sub-directory configs (<design>/<block>/config.mk).
Make's flow/Makefile GENERATE_ABSTRACT_RULE has a second branch:
when there's no per-block config.mk, fall back to a shared
block.mk parameterised by DESIGN_NAME=<block> and
DESIGN_NICKNAME=<parent>_<block>.
flow/designs/asap7/aes-block is the canonical example: it sets
BLOCKS=aes_rcon aes_sbox but the blocks share aes-block/block.mk
rather than each owning a sub-dir config. Before this patch the
parser recorded result.blocks but left result.block_configs empty;
designs.bzl then never added asap7/aes-block_aes_rcon /
asap7/aes-block_aes_sbox entries to DESIGNS;
_create_block_targets looked them up by composite key, got None,
and silently skipped. The parent's synth_odb action ran without
the sub-block .lef/.lib abstracts and the resulting .odb omitted
the two abstract cells (bazel's 1_synth.odb header byte at offset
16 = 212 cells vs make's 214).
Patch carried locally; will be upstreamed. Two changes:
- config_mk_parser.parse() takes an overrides= arg that pins
DESIGN_NAME / DESIGN_NICKNAME after file parsing. BLOCKS
post-processing falls back to shared block.mk and calls
parse() with the appropriate overrides.
- _path_to_label strips a leading "./" before label conversion so
block.mk-style relative paths (e.g.
./designs/asap7/aes/constraint.sdc) don't become malformed
labels (//./designs/asap7/aes:foo.sdc).
Verified on asap7/aes-block: bazel's 1_synth.odb cell-count byte
now matches make's (0xd6 = 214) — sub-block abstracts are read
into the parent synth_odb action.
MODULE.bazel.lock reflects the yosys 0.62.bcr.2 → 0.63 swap; no other
modules move.
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>1 parent 30ae277 commit 3cbfbde
4 files changed
Lines changed: 139 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
13 | 22 | | |
14 | 23 | | |
15 | 24 | | |
| |||
20 | 29 | | |
21 | 30 | | |
22 | 31 | | |
23 | | - | |
24 | 32 | | |
25 | 33 | | |
26 | 34 | | |
| |||
45 | 53 | | |
46 | 54 | | |
47 | 55 | | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
48 | 60 | | |
49 | 61 | | |
50 | 62 | | |
| |||
79 | 91 | | |
80 | 92 | | |
81 | 93 | | |
82 | | - | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
83 | 98 | | |
84 | 99 | | |
85 | 100 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 119 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
0 commit comments