Skip to content

Commit dc44f64

Browse files
oharboeclaude
andcommitted
fix: strip trailing slash from DESIGN_DIR
$(dir ...) in GNU Make always appends a trailing slash, so DESIGN_DIR ended up as e.g. ".../chameleon/". When config.mk files use $(DESIGN_DIR)/gds/file.gds, this produced paths with "//" instead of "/". Mind-bogglingly, this was the only difference we could find that caused CI metric failures (antenna_diodes_count) in PR The-OpenROAD-Project#4080. Strip the trailing slash with $(patsubst %/,%,...) so that replacing custom _DIR variables with DESIGN_DIR is a true no-op. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
1 parent eaeb822 commit dc44f64

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

flow/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ DESIGN_CONFIG ?= ./designs/nangate45/gcd/config.mk
8888
export DESIGN_CONFIG
8989
include $(DESIGN_CONFIG)
9090

91-
export DESIGN_DIR ?= $(dir $(DESIGN_CONFIG))
91+
export DESIGN_DIR ?= $(patsubst %/,%,$(dir $(DESIGN_CONFIG)))
9292

9393
# default value "base" for FLOW_VARIANT and "." for WORK_HOME are duplicated
9494
# from variables.yaml and variables.mk because we need it

0 commit comments

Comments
 (0)