fix(golang): fix gocov exit status, default packages, mktemp, gocd GOPATH check, and completion load order

Author: andremmfaria

plugins/golang/README.md

@@ -10,11 +10,7 @@ Enable the plugin by adding it to your oh-my-bash `plugins` definition in `~/.ba
 plugins=(golang)
 ```
 
-Optionally, enable Go tab completions:
-
-```sh
-completions=(go)
-```
+> **Note:** Tab completion for Go commands is included automatically — no separate `completions=(go)` entry is needed.
 
 ## Aliases
 
@@ -109,17 +105,19 @@ completions=(go)
 
 ### `gocd <package>`
 
-Navigate to a package's source directory under `$GOPATH/src`.
+Navigate to a package's source directory under `$GOPATH/src`. Prints a clear error if `GOPATH` is not set.
 
 ```bash
 gocd github.com/some/package
 ```
 
-### `gocov [go test flags]`
+### `gocov [-flags...] [packages]`
 
-Run tests with a coverage report and open the result in your browser. Accepts the same flags as `go test`; defaults to `./...`.
+Run tests with a coverage report and open the result in your browser. Flags (arguments starting with `-`) are forwarded to `go test`; remaining arguments are treated as packages. If no packages are given, `./...` is used as the default.
 
 ```bash
-gocov              # test all packages + open coverage report
-gocov ./pkg/...    # test a specific subtree
+gocov                      # test ./... + open coverage report
+gocov ./pkg/...            # test a specific subtree
+gocov -run=TestFoo         # run a specific test across ./...
+gocov -run=TestFoo ./pkg/... # run a specific test in a subtree
 ```

plugins/golang/golang.plugin.sh

@@ -2,12 +2,12 @@
 # Description: Aliases and utilities for Go development
 # Inspired by the oh-my-zsh golang plugin (https://github.com/ohmyzsh/ohmyzsh/tree/master/plugins/golang)
 
-_omb_module_require completion:go
-
 if ! _omb_util_command_exists go; then
   return
 fi
 
+_omb_module_require completion:go
+
 # Build
 alias gob='go build'
 alias goba='go build ./...'
@@ -87,17 +87,35 @@ function _omb_plugin_golang_cd {
   fi
   local gopath
   gopath=$(go env GOPATH)
+  if [[ -z $gopath ]]; then
+    _omb_util_print 'gocd: GOPATH is not set or empty' >&2
+    return 1
+  fi
   cd "$gopath/src/$pkg" || return $?
 }
 alias gocd='_omb_plugin_golang_cd'
 
 # Run tests with a coverage report opened in the browser.
-# Usage: gocov [go test flags] (defaults to ./...)
+# Usage: gocov [-go-test-flags...] [packages] (defaults to ./...)
+# Flags (args starting with -) are passed to go test; remaining args are
+# treated as packages. If no packages are given, ./... is used as default.
 function _omb_plugin_golang_cov {
-  local coverfile
-  coverfile=$(mktemp /tmp/go-cover-XXXXXX.out)
-  go test -coverprofile="$coverfile" "${@:-./...}" || { rm -f "$coverfile"; return $?; }
+  local arg flag_args=() pkg_args=()
+  for arg in "$@"; do
+    if [[ $arg == -* ]]; then
+      flag_args+=("$arg")
+    else
+      pkg_args+=("$arg")
+    fi
+  done
+  [[ ${#pkg_args[@]} -eq 0 ]] && pkg_args=(./...)
+
+  local coverfile rc
+  coverfile=$(_omb_util_mktemp) || return 1
+  go test -coverprofile="$coverfile" "${flag_args[@]}" "${pkg_args[@]}" || { rm -f "$coverfile"; return $?; }
   go tool cover -html="$coverfile"
+  rc=$?
   rm -f "$coverfile"
+  return $rc
 }
 alias gocov='_omb_plugin_golang_cov'